Unable to delete web bibles or more than one bible

Bug #1623711 reported by Azaziah
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenLP
Status tracked in Trunk
2.4
Fix Released
Low
Phill
Trunk
Fix Committed
Medium
Phill

Bug Description

When web bible is deleted from the UI, it does not get deleted.
After failed deletion attempt local bibles are not being deleted either.

Deleting normal bibles works for the first bible, but stops working after that.

Win 10, Trunk 2695

The issue seems to be that OpenLP "uses"
the files that are supposed to be deleted:

2016-09-15 17:01:20,489 openlp.core.utils.__init__ ERROR Unable to delete file E:\bzr\data_folder_olp\bibles\Third Millennium Bible.sqlite
Traceback (most recent call last):
  File "openlp\core\utils\__init__.py", line 358, in delete_file
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'E:\\bzr\\data_folder_olp\\bibles\\Third Millennium Bible.sqlite'
2016-09-15 17:01:27,248 openlp.core.utils.__init__ ERROR Unable to delete file E:\bzr\data_folder_olp\bibles\Test.sqlite
Traceback (most recent call last):
  File "openlp\core\utils\__init__.py", line 358, in delete_file
PermissionError: [WinError 32] The process cannot access the file because it is being used by another process: 'E:\\bzr\\data_folder_olp\\bibles\\Test.sqlite'

Related branches

Revision history for this message
Azaziah (suutari-olli) wrote :
Azaziah (suutari-olli)
summary: - Unable to delete web bibles
+ Unable to delete web bibles or more than one bible
description: updated
Azaziah (suutari-olli)
description: updated
Azaziah (suutari-olli)
Changed in openlp:
importance: Undecided → Medium
Revision history for this message
Phill (phill-ridout) wrote :

http://bazaar.launchpad.net/~openlp-core/openlp/trunk/view/head:/openlp/plugins/bibles/lib/manager.py#L181

    bible.session.close()

change it to:

    bible.session.close_all()

Changed in openlp:
status: New → Confirmed
Phill (phill-ridout)
Changed in openlp:
assignee: nobody → Phill (phill-ridout)
Phill (phill-ridout)
Changed in openlp:
status: Confirmed → In Progress
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.