Downloads in private mode are recorded in downloads database
Bug #1625519 reported by
Olivier Tilloy
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| webbrowser-app (Ubuntu) |
Fix Released
|
High
|
Olivier Tilloy | ||
Bug Description
Steps to reproduce:
1) Switch to private mode
2) Browse to any page that has an image, long-press/
3) Choose to download it in-app (as opposed to transferring ownership to another app)
4) Wait for the download to be complete
Expected result: there is no trace of the download in the downloads view.
Current result: the download is visible in the downloads view, even in public mode.
Related branches
lp://qastaging/~osomon/webbrowser-app/private-downloads
- Michael Sheldon (community): Approve
- system-apps-ci-bot: Needs Fixing (continuous-integration)
-
Diff: 1317 lines (+597/-297)9 files modifiedsrc/app/Downloader.qml (+3/-11)
src/app/WebViewImpl.qml (+2/-2)
src/app/webbrowser/Browser.qml (+9/-1)
src/app/webbrowser/DownloadDelegate.qml (+151/-149)
src/app/webbrowser/DownloadsPage.qml (+10/-2)
src/app/webbrowser/downloads-model.cpp (+139/-80)
src/app/webbrowser/downloads-model.h (+7/-9)
src/app/webbrowser/webbrowser-app.qml (+14/-0)
tests/unittests/downloads-model/tst_DownloadsModelTests.cpp (+262/-43)
| Changed in webbrowser-app (Ubuntu): | |
| status: | New → Triaged |
| importance: | Undecided → High |
Revision history for this message
| Olivier Tilloy (osomon) wrote | #1 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | Triaged → In Progress |
| assignee: | nobody → Olivier Tilloy (osomon) |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | In Progress → Fix Released |
To post a comment you must log in.
Just tested how chromium on desktop behaves, when initiating a download from an incognito window:
- as long as the incognito window remains open, the download is visible in all download views in incognito windows only, and it has a little badge to make it clear that it’s an incognito download
- when the last incognito window is closed, re-opening an incognito window won’t show the incognito download in its downloads view
This makes sense, and we should probably emulate this behaviour. To this end, we need to mark incognito downloads in the downloads model so that they are never written to disk, and when leaving incognito mode the model should be purged of incognito downloads.