OpenSRF

Deprecate OSRFGatewayLegacyJSON (/gateway)

Bug #1626139 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Low
Unassigned
Evergreen 3.12-beta
OpenSRF
Confirmed
Low
Unassigned
OpenSRF 3.3-beta

Bug Description

We should remove all traces of OSRFGatewayLegacyJSON from OpenSRF. Its use has been discouraged for a long time, because it produces invalid JSON strings. Keeping it in the codebase just leads to confusion. Time to yank the bandaid.

Revision history for this message
Galen Charlton (gmc) wrote :

Noting that searchAuthority() in Open-ILS/xul/staff_client/server/cat/marcedit.js in Evergreen is a (small) blocker to doing this, at least if we don't want to want for until the XUL client is removed.

Jason Stephenson (jstephenson)
Changed in opensrf:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Galen Charlton (gmc) wrote :

With the release of 3.2, the XUL client is now deprecated, so comment #1 no longer applies.

Bill Erickson (berick)
Changed in opensrf:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

OpenSRF:

https://git.evergreen-ils.org/?p=working/OpenSRF.git;a=shortlog;h=refs/heads/user/berick/lp1626139-byebye-legacy-json-gateway

Evergreen (example config / upgrade note):

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1626139-byebye-legacy-json-gateway

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.12-beta
Changed in opensrf:
milestone: none → 3.3-beta
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Bill Erickson (berick) wrote :

Worth noting the two branches don't have to be released simultaneously. We just need to note on the Evergreen side that upgrading to OpenSRF Version X means modifying your Apache config.

Changed in evergreen:
importance: Undecided → Low
tags: added: deprecation
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Bill! I pushed the Evergreen half of this, with a slight adjustment to the release note due to the order that they are being pushed.

Changed in evergreen:
status: New → Fix Committed
Terran McCanna (tmccanna)
tags: added: signedoff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.