keystone-manage doctor needs tests

Bug #1641621 reported by Steve Martinelli
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Identity (keystone)
Fix Released
Low
Richard

Bug Description

there are no tests for any keystone-manage doctor commands. they should be created here: https://github.com/openstack/keystone/blob/master/keystone/tests/unit/test_cli.py

Richard (csravelar)
Changed in keystone:
assignee: nobody → Richard (csravelar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/406249

Changed in keystone:
status: Triaged → In Progress
Changed in keystone:
assignee: Richard (csravelar) → Steve Martinelli (stevemar)
Changed in keystone:
assignee: Steve Martinelli (stevemar) → Richard (csravelar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/406249
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=bb8be1ec88985fe17c10cf5ffd3a0c3492ddc79d
Submitter: Jenkins
Branch: master

commit bb8be1ec88985fe17c10cf5ffd3a0c3492ddc79d
Author: “Richard <email address hidden>
Date: Fri Dec 2 17:07:37 2016 +0000

    Add unit tests for doctor's caching symptoms

    Currently there are no unit tests for any of doctors symptoms. This
    patch is only adding unit tests for the caching symptoms and more
    will be released for each symptom group in doctor.

    Change-Id: I177ef91206bcad095be06b0607c04c1547994146
    Partial-Bug: #1641621

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/407062

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/407188

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/407188
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=cb7bfce8b3bde3fac1198b179547e6334817f202
Submitter: Jenkins
Branch: master

commit cb7bfce8b3bde3fac1198b179547e6334817f202
Author: “Richard <email address hidden>
Date: Mon Dec 5 20:15:29 2016 +0000

    Add unit tests for doctor federation file

    This patch adds unit tests for the doctor symptoms located in the
    federation file.

    Change-Id: Ide0a0a4bad2d1749effa731111d0d36286c148a7
    Partial-Bug: #1641621

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to keystone (master)

Reviewed: https://review.openstack.org/408218
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=359b10c7e3bdb0af0fe61cc08e68d57d8be02fbc
Submitter: Jenkins
Branch: master

commit 359b10c7e3bdb0af0fe61cc08e68d57d8be02fbc
Author: “Richard <email address hidden>
Date: Wed Dec 7 16:47:05 2016 +0000

    Add doctor check for debug mode enabled

    This patch adds a symptom test to verify that debug mode is not
    enabled. Doing so will eliminate the need to add an additional
    check for debug enabled in other symptom checks like caching and
    database. This also corrects the unit tests that have already been
    added as well as adds a unit test for the new debug symptom.

    Related-Bug: 1641621

    Change-Id: I76750ab3553026583b9fb330bd39f2a134d9c230

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/408743

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/407062
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=aa97a9c0b1081216b649dbe741adf02c38c29bec
Submitter: Jenkins
Branch: master

commit aa97a9c0b1081216b649dbe741adf02c38c29bec
Author: “Richard <email address hidden>
Date: Mon Dec 5 16:34:17 2016 +0000

    Add unit tests for doctor's database symptoms

    This patch adds unit tests for the database file symptoms that doctor
    uses.

    Change-Id: I516a282266b4e4b2e05bf7411202326c637067e9
    Partial-Bug: #1641621

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/409292

Changed in keystone:
assignee: Richard (csravelar) → Samuel de Medeiros Queiroz (samueldmq)
Changed in keystone:
assignee: Samuel de Medeiros Queiroz (samueldmq) → Richard (csravelar)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/408743
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=e4ecc046c8f7adf385a15b74ba16faeeaa19979b
Submitter: Jenkins
Branch: master

commit e4ecc046c8f7adf385a15b74ba16faeeaa19979b
Author: “Richard <email address hidden>
Date: Thu Dec 8 17:41:07 2016 +0000

    Add doctor tests on security_compliance and rename

    This patch adds symptom tests for the checks in doctor
    security_compliance. In addition, this renames one security
    compliance symptom to follow the convention of the other
    symptom names

    Change-Id: Ic47404021c328f74523b00b67cb7d25d43022039
    Partial-Bug: #1641621

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to keystone (master)

Fix proposed to branch: master
Review: https://review.openstack.org/410926

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/410964

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to keystone (master)

Reviewed: https://review.openstack.org/410964
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=c68dc42166ab5d0aff58ff6bd4493236f2ee9160
Submitter: Jenkins
Branch: master

commit c68dc42166ab5d0aff58ff6bd4493236f2ee9160
Author: “Richard <email address hidden>
Date: Wed Dec 14 21:33:58 2016 +0000

    Add unit tests for doctor tokens symptoms

    This patch adds test coverage for the symptoms located in doctors
    tokens file

    Change-Id: I1d2c67715c0e5219aca589f7fbc343e1482338cb
    Partial-Bug: #1641621

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/409289
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=4624f4741e9f049fb3cee90f8ebdc0b6297cdfa2
Submitter: Jenkins
Branch: master

commit 4624f4741e9f049fb3cee90f8ebdc0b6297cdfa2
Author: “Richard <email address hidden>
Date: Fri Dec 9 18:16:08 2016 +0000

    Add checks for doctor credential symptoms

    This patch adds test coverage for doctor symptoms in the credential
    file.

    Change-Id: Ieea310ba448a738af92becff1e798b89869e9496
    Partial-Bug: #1641621

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/410926
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=14179392fc514701da4a4d03814e0c3bae9e1417
Submitter: Jenkins
Branch: master

commit 14179392fc514701da4a4d03814e0c3bae9e1417
Author: “Richard <email address hidden>
Date: Wed Dec 14 19:16:17 2016 +0000

    Add unit tests for doctor token_fernet symptoms

    This patch adds test coverage for token_fernet symptoms located in
    the doctor directory

    Change-Id: I44a401a0402931f35713213a8e5e139976104387
    Partial-Bug: #1641621

Changed in keystone:
milestone: none → ocata-2
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/409292
Committed: https://git.openstack.org/cgit/openstack/keystone/commit/?id=a54ab536c0bfc36e8d08ab6459fc53e6bf2b659e
Submitter: Jenkins
Branch: master

commit a54ab536c0bfc36e8d08ab6459fc53e6bf2b659e
Author: “Richard <email address hidden>
Date: Fri Dec 9 18:30:01 2016 +0000

    Add doctor checks for ldap symptoms

    This patch adds test coverage for ldap symptoms located in the
    ldap file under the doctor directory

    Change-Id: Ie9c1054b360115d1b6fd47e58225fbb8209ae1c6
    Partial-Bug: #1641621

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.