Error on 'delete subnet' in network topology panel

Bug #1643414 reported by qiaomin032
28
This bug affects 6 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Ying Zuo

Bug Description

Cant delete subnet on network topology

Steps to Reproduce:
================
1. Open Project/Network/network topology panel;
2. Click the network icon, and there will display a new modal of the net info
3. Click the 'Delete Subnet' on the new modal.

Actual results:
===========
Subnet does not delete, and there will cast error in the console:
 File "/root/code_review/horizon/horizon/decorators.py", line 84, in dec
    return view_func(request, *args, **kwargs)
  File "/root/code_review/horizon/.venv/lib/python2.7/site-packages/django/views/generic/base.py", line 65, in view
    self = cls(**initkwargs)
  File "/root/code_review/horizon/horizon/tabs/views.py", line 87, in __init__
    super(TabbedTableView, self).__init__(*args, **kwargs)
  File "/root/code_review/horizon/horizon/tables/views.py", line 34, in __init__
    self.get_data_methods(self.table_classes, self._data_methods)
  File "/root/code_review/horizon/horizon/tables/views.py", line 61, in get_data_methods
    name)
  File "/root/code_review/horizon/horizon/tables/views.py", line 78, in check_method_exist
    "in %s." % (func_name, cls_name))
NotImplementedError: You must define a get_subnets_data method in NetworkDetailView.

Expected results:
==============
Subnet should delete

Changed in horizon:
assignee: nobody → qiaomin032 (chen-qiaomin)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (master)

Change abandoned by Rob Cresswell (<email address hidden>) on branch: master
Review: https://review.openstack.org/400042
Reason: Abandoned due to inactivity

Changed in horizon:
status: In Progress → New
assignee: qiaomin032 (chen-qiaomin) → nobody
Ying Zuo (yingzuo)
Changed in horizon:
assignee: nobody → Ying Zuo (yingzuo)
Changed in horizon:
status: New → In Progress
Ying Zuo (yingzuo)
Changed in horizon:
importance: Undecided → Medium
milestone: none → pike-3
Ying Zuo (yingzuo)
Changed in horizon:
milestone: pike-3 → pike-rc1
Revision history for this message
Ying Zuo (yingzuo) wrote :

Gerrit review for this ticket: https://review.openstack.org/#/c/478720

Akihiro Motoki (amotoki)
tags: added: pike-backport-potential
Changed in horizon:
milestone: pike-rc1 → pike-rc2
Ying Zuo (yingzuo)
Changed in horizon:
milestone: pike-rc2 → queens-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/478720
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=fb4ae6bbda8f45429bf1c5f34a61292586847742
Submitter: Jenkins
Branch: master

commit fb4ae6bbda8f45429bf1c5f34a61292586847742
Author: Ying Zuo <email address hidden>
Date: Wed Jun 28 21:08:54 2017 -0700

    Fix subnets can not be deleted from network topology panel

    The structure of DetailView was changed, so the url for the delete
    subnet action needs to be updated so that subnets can be deleted properly.

    Added the required method get_subnets_data in DetailView.

    Added JS code to remove the subnet from the network node on network
    topology panel after the subnet is deleted.

    Fixed router interface not being removed from the network topology
    panel after it's deleted.

    Closes-bug: #1643414

    Change-Id: I60cc161655b994c8e3ace5efc37459f3e9e60d67

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/509303

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/511399

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/pike)

Reviewed: https://review.openstack.org/509303
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=55f246115cc1562ad59c8eeaac6af53be328327d
Submitter: Zuul
Branch: stable/pike

commit 55f246115cc1562ad59c8eeaac6af53be328327d
Author: Ying Zuo <email address hidden>
Date: Wed Jun 28 21:08:54 2017 -0700

    Fix subnets can not be deleted from network topology panel

    The structure of DetailView was changed, so the url for the delete
    subnet action needs to be updated so that subnets can be deleted properly.

    Added the required method get_subnets_data in DetailView.

    Added JS code to remove the subnet from the network node on network
    topology panel after the subnet is deleted.

    Fixed router interface not being removed from the network topology
    panel after it's deleted.

    Closes-bug: #1643414

    Change-Id: I60cc161655b994c8e3ace5efc37459f3e9e60d67
    (cherry picked from commit fb4ae6bbda8f45429bf1c5f34a61292586847742)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 13.0.0.0b1

This issue was fixed in the openstack/horizon 13.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (stable/ocata)

Change abandoned by Marek Lyčka (<email address hidden>) on branch: stable/ocata
Review: https://review.openstack.org/511399

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 12.0.1

This issue was fixed in the openstack/horizon 12.0.1 release.

Akihiro Motoki (amotoki)
tags: removed: pike-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.