Inconsistent output of offloading modes

Bug #1643801 reported by Julia Aranovich
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Won't Fix
Medium
Fuel Sustaining
Mitaka
Confirmed
Medium
Fuel Sustaining

Bug Description

/api/nodes/x/interfaces returns the following NIC's data related to offloading modes:

{
  attributes: {
    offloading: {
      value: { // offloading modes values are stored here
        mode1: true,
        mode2: false,
        ...
      }
    },
    ...
  },
  meta: {
    offloading_modes: [ // offloading modes structure is described here
      {
        name: 'mode1',
        state: true,
        sub: [{
          name: 'mode2',
          state: false,
          sub: []
        }]
      },
      ...
    ]
  },
  offloading_modes: {...}, // unuseful data
  ...
}

There are a few inconsistencies:

1) NIC's offloading_modes attribute is redundant. All its data already exists in attributes.offloafing and meta.offloading_modes. Direct offloading_modes attribute should be removed

2) meta.offloading_modes should be renamed to meta.offloading to be consistent with offloading attribute name (attributes.offloafing)

3) state fields should be removed from meta.offloading_modes. They are not useful at all. meta.offloading_modes should store information about modes structure only.

Revision history for this message
Julia Aranovich (jkirnosova) wrote :

The 1) item from the task list is fixed in https://review.openstack.org/340762

Changed in fuel:
assignee: Andriy Popovych (popovych-andrey) → Fuel Sustaining (fuel-sustaining-team)
importance: High → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/414932

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (stable/mitaka)

Reviewed: https://review.openstack.org/414932
Committed: https://git.openstack.org/cgit/openstack/fuel-web/commit/?id=a1902a589b95f2eb6e22373975651345dbecd33e
Submitter: Jenkins
Branch: stable/mitaka

commit a1902a589b95f2eb6e22373975651345dbecd33e
Author: Andriy Popovych <email address hidden>
Date: Mon Dec 26 13:06:19 2016 +0200

    Remove offloading modes from model

    Change-Id: I18db4bbcc86c9cb26660f28673723a06a4398bbb
    Closes-Bug: #1650521
    Partial-Bug: #1643801

tags: added: in-stable-mitaka
Roman Vyalov (r0mikiam)
Changed in fuel:
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.