[2.1] MAAS fails to add SSH keys if server has duplicate keys
Bug #1651280 reported by
Andres Rodriguez
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
High
|
Alberto Donato | ||
| 2.3 |
Fix Released
|
High
|
Alberto Donato | ||
Bug Description
MAAS fails to add SSH keys (from a launchpad source, although we can safely assume it is wide spread), if the server contains duplicate keys.
For example:
ubuntu@
2016-12-19 23:40:09,420 INFO Starting new HTTPS connection (1): launchpad.net
[...]
2016-12-19 23:40:10,718 INFO Already authorized ['4096', 'SHA256:
2016-12-19 23:40:10,721 INFO Already authorized ['4096', 'SHA256:
[...]
But in MAAS it shows an error message:
"This key has already been added for this user."
Related branches
~ack/maas:ssh-key-from-source-update
- Alberto Donato (community): Approve
-
Diff: 70 lines (+42/-1)2 files modifiedsrc/maasserver/models/keysource.py (+3/-1)
src/maasserver/models/tests/test_keysource.py (+39/-0)
~ack/maas:ssh-key-from-source-update
- Lee Trager (community): Approve
- MAAS Lander: Approve
-
Diff: 70 lines (+42/-1)2 files modifiedsrc/maasserver/models/keysource.py (+3/-1)
src/maasserver/models/tests/test_keysource.py (+39/-0)
Revision history for this message
| Mike Pontillo (mpontillo) wrote | #1 |
| summary: |
- [2.1] MAAS fails to add SSH keys is server has duplicate keys + [2.1] MAAS fails to add SSH keys if server has duplicate keys |
| Changed in maas: | |
| milestone: | 2.2.0 → 2.2.x |
| no longer affects: | maas/trunk |
| Changed in maas: | |
| milestone: | 2.2.x → 2.3.0 |
| no longer affects: | maas/2.1 |
| Changed in maas: | |
| milestone: | 2.3.0 → 2.3.x |
Revision history for this message
| Alberto Donato (ack) wrote | #2 |
| Changed in maas: | |
| status: | Triaged → Incomplete |
Revision history for this message
| Alberto Donato (ack) wrote | #3 |
| Changed in maas: | |
| status: | Incomplete → Triaged |
| Changed in maas: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Alberto Donato (ack) |
| Changed in maas: | |
| milestone: | 2.3.x → 2.3.0 |
| Changed in maas: | |
| milestone: | 2.3.0 → 2.4.x |
| no longer affects: | maas/trunk |
| Changed in maas: | |
| milestone: | 2.3.1 → 2.4.0alpha1 |
| Changed in maas: | |
| milestone: | 2.4.0alpha1 → 2.4.x |
| status: | In Progress → Fix Committed |
| status: | Fix Committed → In Progress |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
| milestone: | 2.4.x → 2.4.0alpha1 |
To post a comment you must log in.
Yes, I think this should silently succeed. No need to warn the user about duplicate keys, whether they are added manually or automatically.