Agent crash - NULL pointer access

Bug #1655898 reported by Hari Prasad Killi
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.1
Fix Committed
High
Hari Prasad Killi
R3.2
Invalid
High
Hari Prasad Killi
Trunk
Invalid
High
Hari Prasad Killi

Bug Description

(gdb) bt
#0 AgentDBEntry::IsActive (this=this@entry=0x68) at controller/src/vnsw/agent/cmn/agent_db.cc:28
#1 0x0000000000d0e387 in NhDecode (nh=<optimized out>, nh@entry=0x7f29d81ff920, pkt=pkt@entry=0x7f29c0389ad0, info=info@entry=0x7f29e6400880, in=in@entry=0x7f29e6400800,
    out=out@entry=0x7f29e6400840, force_vmport=force_vmport@entry=false, ecmp_load_balance=...) at controller/src/vnsw/agent/pkt/pkt_flow_info.cc:314
#2 0x0000000000d0e840 in NhDecode (ecmp_load_balance=..., force_vmport=false, out=0x7f29e6400840, in=0x7f29e6400800, info=0x7f29e6400880, pkt=0x7f29c0389ad0, nh=0x7f29d81ff920)
    at controller/src/vnsw/agent/pkt/pkt_flow_info.cc:420
#3 RouteToOutInfo (rt=<optimized out>, pkt=pkt@entry=0x7f29c0389ad0, info=info@entry=0x7f29e6400880, in=in@entry=0x7f29e6400800, out=out@entry=0x7f29e6400840)
    at controller/src/vnsw/agent/pkt/pkt_flow_info.cc:420
#4 0x0000000000d108b3 in PktFlowInfo::IngressProcess (this=this@entry=0x7f29e6400880, pkt=pkt@entry=0x7f29c0389ad0, in=in@entry=0x7f29e6400800, out=out@entry=0x7f29e6400840)
    at controller/src/vnsw/agent/pkt/pkt_flow_info.cc:1194
#5 0x0000000000d113d5 in PktFlowInfo::Process (this=this@entry=0x7f29e6400880, pkt=0x7f29c0389ad0, in=in@entry=0x7f29e6400800, out=out@entry=0x7f29e6400840)
    at controller/src/vnsw/agent/pkt/pkt_flow_info.cc:1493
#6 0x0000000000d20962 in FlowHandler::Run (this=0x7f29c03895f0) at controller/src/vnsw/agent/pkt/flow_handler.cc:114
#7 0x0000000000d19c74 in RunProtoHandler (handler=0x7f29c03895f0, this=0x7f29e6400a60) at controller/src/vnsw/agent/pkt/proto.cc:51
#8 Proto::ProcessProto (this=this@entry=0x7f29e0af98c0, msg_info=(boost::shared_ptr<PktInfo>) (count 4, weak count 1) 0x7f29c0389ad0) at controller/src/vnsw/agent/pkt/proto.cc:66
#9 0x0000000000cfce68 in FlowProto::FlowEventHandler (this=0x7f29e0af98c0, req=0x7f29c0389c20, table=0x7f29e297cda0) at controller/src/vnsw/agent/pkt/flow_proto.cc:405
#10 0x0000000000d1dc1d in FlowEventQueueBase::Handler (this=0x7f29b8802ca0, event=0x7f29c0389c20) at controller/src/vnsw/agent/pkt/flow_event.cc:105
#11 0x0000000000d01f12 in operator() (a0=0x7f29c0389c20, this=0x7f29e6400b30) at /usr/include/boost/function/function_template.hpp:767
#12 QueueTaskRunner<FlowEvent*, WorkQueue<FlowEvent*> >::RunQueue (this=0x7f29c028e6d0) at controller/src/base/queue_task.h:92
#13 0x00000000012f3a8f in TaskImpl::execute (this=0x7f29e7da7640) at controller/src/base/task.cc:262

Revision history for this message
Hari Prasad Killi (haripk) wrote :

(gdb) python dump_route_paths(0x7f29d43978a0)
Number of paths : 2

Path : 0x7f29d43973e0 Peer : (boost::intrusive_ptr<Peer const>) 0x7f29cc00fd50 NH : 0x7f29d437b590 Label : 33

Number of paths : 2

Path : 0x7f29d438ac50 Peer : (boost::intrusive_ptr<Peer const>) 0x7f29d80096d0 NH : 0x7f29d437b590 Label : 33

Local nexthop is not there, causing the crash.

tags: added: sanity
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/27855
Submitter: Hari Prasad Killi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/27855
Committed: http://github.org/Juniper/contrail-controller/commit/94a6f2cf36b4eeaa8b3c3f139fb948b2d2310b4e
Submitter: Zuul (<email address hidden>)
Branch: R3.1

commit 94a6f2cf36b4eeaa8b3c3f139fb948b2d2310b4e
Author: Hari <email address hidden>
Date: Thu Jan 12 15:24:19 2017 +0530

Local nexthop could be already removed, add NULL check.

Change-Id: I01543bf36604e61c6302f92ecbb59c8b3fc3dd24
closes-bug: #1655898

Jeba Paulaiyan (jebap)
tags: added: blocker
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.1

Review in progress for https://review.opencontrail.org/27911
Submitter: Hari Prasad Killi (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/27911
Committed: http://github.org/Juniper/contrail-controller/commit/71b4f4277727f94f9f8eb5b3255f871a7e545329
Submitter: Zuul (<email address hidden>)
Branch: R3.1

commit 71b4f4277727f94f9f8eb5b3255f871a7e545329
Author: Hari <email address hidden>
Date: Mon Jan 16 10:49:15 2017 +0530

Update the NULL check

Change-Id: I9e2989a01d37d46a68f24af4f690e8de4a9d55e5
closes-bug: #1655898

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.