tripleo

Validations translations not showing in UI until refresh

Bug #1662973 reported by Julie Pichon on 2017-02-08

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	Medium	Jiri Tomasek	tripleo ocata-rc2 "ocata-rc2"

Bug Description

Steps to reproduce:
-------------------
1. Login to the UI
2. Select another language, e.g. Japanese

Expected results:
-----------------
3. The entire (javascript parts) UI switches to Japanese

Actual results:
---------------
3. The main pane on the left refreshes. However, the Validations panel, title, buttons, validation details still appears in English, until the Refresh button is pressed. (Then everything, including the details popup appears correctly in Japanese.)

Maybe we can trigger a refresh on language change...?

Another issue that may or may not be related:
- In the navigation bar, Logout switches to Japanese directly, but "Language" doesn't. I needed to refresh the entire webpage for it to be shown in Japanese

(I can file this in a separate bug if preferred.)

Tags:

Revision history for this message

Jiri Tomasek (jtomasek) wrote on 2017-02-10:

all this gets IMHO fixed by adding this.props.detectLanguage(MESSAGES); to componentWillReceiveProps in I18nProvider (under a condition that a language has changed)

Changed in tripleo:
assignee:	nobody → Jiri Tomasek (jtomasek)

Revision history for this message

Jiri Tomasek (jtomasek) wrote on 2017-02-10:

Ok, after further investigation, it seems that the components which don't get updated have no props, so when language is changed, component does not get updated.

Revision history for this message

Jiri Tomasek (jtomasek) wrote on 2017-02-10:

https://github.com/yahoo/react-intl/issues/371#issuecomment-210822027

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-02-10: Fix proposed to tripleo-ui (master)

Fix proposed to branch: master
Review: https://review.openstack.org/432365

Changed in tripleo:
status:	Triaged → In Progress

Emilien Macchi (emilienm) on 2017-02-16

Changed in tripleo:
milestone:	ocata-rc1 → ocata-rc2

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-02-23: Fix merged to tripleo-ui (master)

Reviewed: https://review.openstack.org/432365
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=1dedd736df2f0f0b43358e341fe88e7547529b92
Submitter: Jenkins
Branch: master

commit 1dedd736df2f0f0b43358e341fe88e7547529b92
Author: Jiri Tomasek <email address hidden>
Date: Fri Feb 10 16:58:50 2017 +0100

Make connected components update on lang. switch

    When language is switched, connected components which aren't
    injecting intl don't get props updated and language switch is not
    reflected. This change wraps all connected components in injectIntl

Closes-Bug: #1662973
Change-Id: Ie38a7c5538b54e6abc7f3723c1285c9ce2a516e8

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-02-23: Fix proposed to tripleo-ui (stable/ocata)

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/437580

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-02-23: Fix merged to tripleo-ui (stable/ocata)

Reviewed: https://review.openstack.org/437580
Committed: https://git.openstack.org/cgit/openstack/tripleo-ui/commit/?id=15169ea6c6547d623f52b92c06e550ae559b7ab8
Submitter: Jenkins
Branch: stable/ocata

commit 15169ea6c6547d623f52b92c06e550ae559b7ab8
Author: Jiri Tomasek <email address hidden>
Date: Fri Feb 10 16:58:50 2017 +0100

Make connected components update on lang. switch

    Closes-Bug: #1662973
    Change-Id: Ie38a7c5538b54e6abc7f3723c1285c9ce2a516e8
    (cherry picked from commit 1dedd736df2f0f0b43358e341fe88e7547529b92)