Code regression caused by revision 1108
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Duplicity |
Fix Released
|
Medium
|
Unassigned |
Bug Description
Revision 1108 modified util.py, changing this:
return uexc(msg)
to this:
return util.uexc(msg)
But the uexc() function isn't in a package. It causes the exception below. Just remove the "util." and it's fixed.
Traceback (most recent call last):
File "/usr/bin/
main()
File "/usr/bin/
patch(
File "/usr/bin/
patchdir.
File "/usr/lib64/
patch_
File "/usr/lib64/
ITR(
File "/usr/lib64/
self.
File "/usr/lib64/
branch.
File "/usr/lib64/
return function(*args)
File "/usr/lib64/
self.
File "/usr/lib64/
basis_
File "/usr/lib64/
diff_
File "/usr/lib64/
util.
File "/usr/lib64/
% (e.__class_
NameError: global name 'util' is not defined
Changed in duplicity: | |
importance: | Undecided → Medium |
milestone: | none → 0.7.12 |
status: | New → Fix Committed |
Changed in duplicity: | |
status: | Fix Committed → Fix Released |
The change was made in revision 1165 of duplicity. Rev 1108 did not change
util.py.
Fixing now. Will be out in 0.7.12 in a few days.
On Fri, Mar 10, 2017 at 9:31 AM, David Coppit <email address hidden> wrote:
> Public bug reported: rdiffdir" , line 250, in <module> rdiffdir" , line 237, in main file_args[ 1], "rb")) rdiffdir" , line 207, in patch Patch(path. Path(dirname) , deltafp) python2. 7/site- packages/ duplicity/ patchdir. py", line tarfile( base_path, diff_tarfile) python2. 7/site- packages/ duplicity/ patchdir. py", line path.index, basis_path, diff_ropath) python2. 7/site- packages/ duplicity/ lazy.py" , line 329, w_branch( index, self.root_branch, args) python2. 7/site- packages/ duplicity/ lazy.py" , line 302, start_process, args) python2. 7/site- packages/ duplicity/ robust. py", line 38, python2. 7/site- packages/ duplicity/ patchdir. py", line process( index, basis_path, diff_ropath) python2. 7/site- packages/ duplicity/ patchdir. py", line patch_with_ attribs( diff_ropath) python2. 7/site- packages/ duplicity/ path.py" , line 660, copy_attribs( temp_path) python2. 7/site- packages/ duplicity/ path.py" , line 468, ignore_ errors( lambda: os.chown( other.name, python2. 7/site- packages/ duplicity/ util.py" , line 97, _.__name_ _, util.uexc(e))) /bugs.launchpad .net/bugs/ 1671852 rdiffdir" , line 250, in <module> rdiffdir" , line 237, in main file_args[ 1], "rb")) rdiffdir" , line 207, in patch Patch(path. Path(dirname) , deltafp)
>
> Revision 1108 modified util.py, changing this:
>
> return uexc(msg)
>
> to this:
>
> return util.uexc(msg)
>
> But the uexc() function isn't in a package. It causes the exception
> below. Just remove the "util." and it's fixed.
>
> Traceback (most recent call last):
> File "/usr/bin/
> main()
> File "/usr/bin/
> patch(file_args[0], get_fileobj(
> File "/usr/bin/
> patchdir.
> File "/usr/lib64/
> 50, in Patch
> patch_diff_
> File "/usr/lib64/
> 83, in patch_diff_tarfile
> ITR(basis_
> File "/usr/lib64/
> in __call__
> self.process_
> File "/usr/lib64/
> in process_w_branch
> branch.
> File "/usr/lib64/
> in check_common_error
> return function(*args)
> File "/usr/lib64/
> 265, in start_process
> self.fast_
> File "/usr/lib64/
> 310, in fast_process
> basis_path.
> File "/usr/lib64/
> in patch_with_attribs
> diff_ropath.
> File "/usr/lib64/
> in copy_attribs
> util.maybe_
> self.stat.st_uid, self.stat.st_gid))
> File "/usr/lib64/
> in maybe_ignore_errors
> % (e.__class_
> NameError: global name 'util' is not defined
>
> ** Affects: duplicity
> Importance: Undecided
> Status: New
>
> --
> You received this bug notification because you are subscribed to
> Duplicity.
> https:/
>
> Title:
> Code regression caused by revision 1108
>
> Status in Duplicity:
> New
>
> Bug description:
> Revision 1108 modified util.py, changing this:
>
> return uexc(msg)
>
> to this:
>
> return util.uexc(msg)
>
> But the uexc() function isn't in a package. It causes the exception
> below. Just remove the "util." and it's fixed.
>
> Traceback (most recent call last):
> File "/usr/bin/
> main()
> File "/usr/bin/
> patch(file_args[0], get_fileobj(
> File "/usr/bin/
> patchdir.
> File "/us...