rpl_diff.inc in 5.7 does not compare data from different servers

Here is an excerpt from rpl_diff.inc:

*********************************************
# Compare all servers.
--let $_rpl_diff_first= 1
while ($_rpl_diff_servers)
{
  # Set $_rpl_diff_server_i to the first number in the list
  --let $_rpl_diff_server_i= `SELECT SUBSTRING_INDEX('$_rpl_diff_servers', ',', 1)`
  # Remove $_rpl_diff_server_i from the list
  --let $_rpl_diff_servers= `SELECT SUBSTRING('$_rpl_diff_servers', LENGTH('$_rpl_diff_server_i') + 2)`

  # Execute statement
  --let $_rpl_diff_file= $MYSQLTEST_VARDIR/tmp/_rpl_diff_server-$_rpl_diff_server_i.tmp
  --exec $MYSQL $_rpl_diff_database < $_rpl_diff_statement_file > $_rpl_diff_file

  # Compare
  if (!$_rpl_diff_first)
  {
    if ($rpl_debug)
    {
      --echo diffing $_rpl_diff_file and $_rpl_diff_prev_file
    }
    --diff_files $_rpl_diff_file $_rpl_diff_prev_file
    --remove_file $_rpl_diff_prev_file
  }
  --let $_rpl_diff_prev_file= $_rpl_diff_file
  --let $_rpl_diff_first= 0
}
--remove_file $_rpl_diff_prev_file
*********************************************

Although the script properly iterates over servers, it always executes $MYSQL with default connection parameters
--exec $MYSQL $_rpl_diff_database < $_rpl_diff_statement_file > $_rpl_diff_file

This is an upstream bug introduced in commit 61e2172 "BUG#20136704 --SLAVE-PRESERVE-COMMIT-ORDER CAUSES SLAVE TO DEADLOCK AND BREAK FOR SOME QUERIE"

https://github.com/mysql/mysql-server/commit/61e2172a1885172aec9814fa7ece5a3176547634

Suggested fix:

Change
--exec $MYSQL $_rpl_diff_database < $_rpl_diff_statement_file > $_rpl_diff_file

back to
--exec $MYSQL --defaults-group-suffix=.$_rpl_diff_server_i $_rpl_diff_database < $_rpl_diff_statement_file > $_rpl_diff_file

in 'include/rpl_diff.inc'

This is a 5.7-only bug. Both 5.5. and 5.6 have proper '--defaults-group-suffix=.$_rpl_diff_server_i' argument.

This include also does not remove generated $_rpl_diff_statement_file file at the end.

https://github.com/percona/percona-server/pull/1637
https://github.com/percona/percona-server/pull/1638
https://github.com/percona/percona-server/pull/1639

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-2257