Hardcoded paths in many support scripts

Working branch user/jeffdavis/lp1693851-support-scripts-hardcoded-paths contains two commits:

(1) A fix for the srfsh scripts, using BINDIR and substituting the correct path during build:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=c13436b0

(2) A fix for the Perl scripts, using a relative path for oils_header.pl:
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commitdiff;h=f265cb1c

While we're at it, a few scripts don't have paths and either need to be run directly from /openils/bin or with that in the path, which makes running them from sudo nearly impossible.

Can we fix those with this branch also, or should I open a new bug for those?

I tested this yesterday and received an error in the makefile

sed -i 's|BINDIR|/openils/bin|g' '/openils/bin/generate_fines.srfsh'
sed: can't read /openils/bin/generate_fines.srfsh: No such file or directory
Makefile:1010: recipe for target 'ilscore-install' failed

It looks like generate_fines.srfsh was replaced with fine_generator.pl in 2006? The commit messages mentions that the .srfsh version only has a 1mb buffer.

Open-ILS/src/Makefile.am only mentions installing fine_generator.pl, and the crontab examples use fine_generator.pl.

Should I start a bug for removing generate_fines.srfsh?
Josh

I did a little more looking and neither of these scripts are installed during the install, I think they have both been superseded.

generate_fines.srfsh
hold_copy_targeter.srfsh

I don't think those should be included in your patch for the srfsh scripts.

Neither of the perl scripts you included are included in the install either. Also, the oils_header.pl script isn't included in the install, I just checked our system and found that there were updates for oils_header.pl from Nov 2015 that we are not using because the install process doesn't update it. Bug 741788 mentions that oils_header.pl needs to be installed during make install.

And it seems to me that making the path relative causes the problem that Jason mentions, about needing /openils/bin in the path for the script to run, which makes using sudo hard for those scripts. I think that converting those over to the BINDIR substitution would work better, but only after/when they are included in the install.

The rollover_phone_to_print.pl requires config info be set in the script, so just overwriting it on install is problematic right now. I needs a config file or it should use opensrf.xml to store it's settings.

So here is a branch that only includes the srfsh scripts that are included in the install, and doesn't include the perl script commit. I think this will work without errors now.
http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1693851-support-scripts-hardcoded-paths

Josh

It looks like Galens working branch for installing the marc stream importer includes a fix for the relative path issue in perl scripts using FindBin.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/gmcharlt/lp741788_wip

-require 'oils_header.pl';
+use FindBin;
+require "$FindBin::Bin/oils_header.pl";

Josh

I've pushed the patch with Josh's signoff that touches only the srfsh scripts to master and rel_2_12. Thanks, Jeff and Josh!

I'll open a new bug for the remaining Perl files.

And that bug is bug 1709160