kolla-ansible

One notify in keystone is not correct

Bug #1699924 reported by jiangpengcheng on 2017-06-23

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
kolla-ansible	Fix Released	Medium	zhongshengping	kolla-ansible pike-3 "pike"
Ocata	Fix Released	Undecided	Unassigned	kolla-ansible 4.0.3 "ocata"
Pike	Fix Released	Medium	zhongshengping	kolla-ansible pike-3 "pike"

Bug Description

There is a notify "Restart keystone containers" in `roles/keystone/tasks/config.yml`:

```
- name: Copying over existing policy.json
  template:
    src: "{{ node_custom_config }}/keystone/policy.json"
    dest: "{{ node_config_directory }}/{{ item.key }}/policy.json"
  register: keystone_policy_jsons
  when:
    - inventory_hostname in groups[item.value.group]
    - item.key in [ "keystone", "keystone-fernet" ]
    - item.value.enabled | bool
    - keystone_policy.stat.exists
  with_dict: "{{ keystone_services }}"
  notify:
    - Restart keystone containers
```

But no handler named "Restart keystone containers" is defined, so when user use a custom policy file for keystone, the deployment will be failed.

And according to the context, both keystone and keystone-fernet containers should be restarted.

jiangpengcheng (jiangpengcheng) on 2017-06-23

Changed in kolla-ansible:
assignee:	nobody → jiangpengcheng (jiangpengcheng)

raja (jiangpch) on 2017-06-23

Changed in kolla-ansible:
assignee:	jiangpengcheng (jiangpengcheng) → raja (jiangpch)

zhongshengping (chdzsp) on 2017-06-23

Changed in kolla-ansible:
assignee:	raja (jiangpch) → zhongshengping (chdzsp)
assignee:	zhongshengping (chdzsp) → nobody

Eduardo Gonzalez (egonzalez90) on 2017-06-23

Changed in kolla-ansible:
status:	New → In Progress
importance:	Undecided → Medium
milestone:	none → pike-3

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-06-26: Fix merged to kolla-ansible (master)

Reviewed: https://review.openstack.org/476298
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=77358dd920c1abab64d111496d94a77b9e5ca6c3
Submitter: Jenkins
Branch: master

commit 77358dd920c1abab64d111496d94a77b9e5ca6c3
Author: jiangpch <email address hidden>
Date: Wed Jun 21 20:59:40 2017 -0400

The notify "Restart keystone containers" is not correct

No handler named "Restart keystone containers", and we should restart
the keystone and the keystone-fernet container according to the context

Closes-Bug: #1699924

Change-Id: I62512dc022426cc762ff603d8554e48651fa621f

Changed in kolla-ansible:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-07-27: Fix included in openstack/kolla-ansible 5.0.0.0b3

This issue was fixed in the openstack/kolla-ansible 5.0.0.0b3 development milestone.

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2017-12-18: Fix merged to kolla-ansible (stable/ocata)

Reviewed: https://review.openstack.org/528612
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=56d59337801a9b25cb28c5cdf38aa580dd6ebbd8
Submitter: Zuul
Branch: stable/ocata

commit 56d59337801a9b25cb28c5cdf38aa580dd6ebbd8
Author: jiangpch <email address hidden>
Date: Wed Jun 21 20:59:40 2017 -0400

The notify "Restart keystone containers" is not correct

No handler named "Restart keystone containers", and we should restart
the keystone and the keystone-fernet container according to the context

Closes-Bug: #1699924

Change-Id: I62512dc022426cc762ff603d8554e48651fa621f
(cherry picked from commit 77358dd920c1abab64d111496d94a77b9e5ca6c3)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2018-04-02: Fix included in openstack/kolla-ansible 4.0.4

This issue was fixed in the openstack/kolla-ansible 4.0.4 release.

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.