networking-midonet

enable the rest of pep8 checks

Bug #1702908 reported by YAMAMOTO Takashi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
networking-midonet
Fix Released
Wishlist
YAMAMOTO Takashi
networking-midonet 5.0.0

Bug Description

there are pep8 checks disabled for no good reasons.

YAMAMOTO Takashi (yamamoto)
tags: added: midokura-jira-tracked
Changed in networking-midonet:
importance: Undecided → Wishlist
YAMAMOTO Takashi (yamamoto)
Changed in networking-midonet:
assignee: nobody → YAMAMOTO Takashi (yamamoto)
milestone: none → 5.0.0
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to networking-midonet (master)

Fix proposed to branch: master
Review: https://review.openstack.org/481694

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/481695

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/481697

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/481698

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to networking-midonet (master)

Reviewed: https://review.openstack.org/481694
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=250eb582b191a91a45fd4258cad1cd850c550bba
Submitter: Jenkins
Branch: master

commit 250eb582b191a91a45fd4258cad1cd850c550bba
Author: YAMAMOTO Takashi <email address hidden>
Date: Sat Jul 8 00:38:14 2017 +0900

    pep8: Enable E125, E126, E128

    E125 continuation line does not distinguish itself from next logical line
    E126 continuation line over-indented for hanging indent
    E128 continuation line under-indented for visual indent

    Partial-Bug: #1702908
    Change-Id: I9b5f0357a6cf6d09f8e877e79e305abc9922a2ae

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/481695
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=cb92b0b7814bdf050363d33d186cd159585162e1
Submitter: Jenkins
Branch: master

commit cb92b0b7814bdf050363d33d186cd159585162e1
Author: YAMAMOTO Takashi <email address hidden>
Date: Sat Jul 8 00:57:46 2017 +0900

    pep8: Enable H404 and H405

    H404 multi line docstring should start with a summary
    H405 multi line docstring summary not separated with an empty line

    Partial-Bug: #1702908
    Change-Id: I643db3c51ac7a7b952f6fb072c641d83c5747472

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/481697
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=95e91f34f3ea36481ea0cf97abd85f3d5644d4c0
Submitter: Jenkins
Branch: master

commit 95e91f34f3ea36481ea0cf97abd85f3d5644d4c0
Author: YAMAMOTO Takashi <email address hidden>
Date: Sat Jul 8 01:36:35 2017 +0900

    Remove log translation markers

    Also, enable N537 as it should be safe now.

    Partial-Bug: #1702908
    Change-Id: Ia3d97cd458994b16a185ee3f259b899d1cd92d01

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/481698
Committed: https://git.openstack.org/cgit/openstack/networking-midonet/commit/?id=dfa1e4dda26a6580d38cfebad7887313297d6552
Submitter: Jenkins
Branch: master

commit dfa1e4dda26a6580d38cfebad7887313297d6552
Author: YAMAMOTO Takashi <email address hidden>
Date: Sat Jul 8 01:45:54 2017 +0900

    pep8: Enable H106, H203, H904

    Copy and paste from Neutron.

    Closes-Bug: #1702908
    Change-Id: I7d092702e9c7212016741019019fe296cc1a69e9

Changed in networking-midonet:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/networking-midonet 5.0.0.0b3

This issue was fixed in the openstack/networking-midonet 5.0.0.0b3 development milestone.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.