XUL Patron Registration: Circ is behind desk isn't hidden based on YAOUS

Proposed fix at : http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1706148_hide_behind_desk_option

I also tested the user setting type default value feature with this, and that worked as expected, any value as the default is treated as true and checks the checkbox.

Josh

Testing

I have tested it, and it behaves as advertised. I just have a question about the logic.

Does the patron checkbox mean "If it is possible to hold something behind the desk, do it"? This checkbox's visibility is not tied to the selection for the default hold pickup location -- it seems to be totally independent.

If that's the case, then the only case where it would make sense to display the checkbox is when there is at least one possible pickup location in the whole org tree where behind-the-desk pickup is allowed.

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dpearl/lp1706148_hide_behind_desk_option_signoff

Dan, thanks for testing. We don't use the feature so I don't know if the situation you mentioned is an issue. I was mainly concerned with getting rid of it. I think the webclient fix for the issue would have the same problem.

It looks like this gotcha was known when the feature was enhanced.

http://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=54bc2edb1e4bfceaba08e9526389aebd60dbf830;hp=347e376ee8e2ce9967ddd446376721f0e637340a

http://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/perlmods/lib/OpenILS/WWW/EGCatLoader/Account.pm#l582

+ # if behind-desk holds are supported and the user
+ # setting which controls the value is opac-visible,
+ # add the setting to the list of settings to manage.
+ # note: this logic may need to be changed later to
+ # check whether behind-the-desk holds are supported
+ # anywhere the patron may select as a pickup lib.

I think we need to hear from someplace that does use it in a consortium where some ou's allow it and others don't.

It seem reasonable to me that if my library doesn't support this feature, then I cannot call them and ask them about changing it. If I called the pickup location that does support it, they would be able to answer questions about it and would be able to change the pref on my account... if they had the correct permissions.
Josh

Pushed to master, rel_2_12, and rel_2_11. Thanks, Josh!

I tend to agree that some additional clarity is needed regarding how consortia that use this feature expect it to be handled if some libraries enable behind-desks holds and others do not.