OpenStack Dashboard (Horizon)

tox -e manage -- extract_messages mixes horizon and openstack_dashboard catalogs

Bug #1710396 reported by Akihiro Motoki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
High
Akihiro Motoki
OpenStack Dashboard (Horizon) queens-1

Bug Description

when we run tox -e manage -- extract_messages, we will get message catalogs both for horizon and openstack_dashboard but each message catalogs contains strings from both horizon and openstack_dashboard.
horizon message catalogs should contains only horizon strings and same for openstack_dashboard.

http://paste.openstack.org/show/618249/

See original description
Akihiro Motoki (amotoki)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/493320

Changed in horizon:
status: New → In Progress
Akihiro Motoki (amotoki)
tags: added: i18n
removed: pike-backport-potential
Rob Cresswell (robcresswell-deactivatedaccount)
Changed in horizon:
importance: Medium → High
tags: added: pike-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/493320
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=19a4012b9119643a612cf5d61be5c7d8ed128a65
Submitter: Jenkins
Branch: master

commit 19a4012b9119643a612cf5d61be5c7d8ed128a65
Author: Akihiro Motoki <email address hidden>
Date: Sat Aug 12 17:52:31 2017 +0000

    extract_messages: Specify input directory

    Currently horizon/locale/{django,djangojs}.js contain strings from
    openstack_dashboard and vice versa. To avoid this, --input-dirs
    option needs to be passed to python setup.py extract_messages.

    Change-Id: Iee874616f4c037cc68bc3b0c7d8586d86f7153f4
    Closes-Bug: #1710396

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 13.0.0.0b1

This issue was fixed in the openstack/horizon 13.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/534353

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/pike)

Reviewed: https://review.openstack.org/534353
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=fb6ff76eabdb9abeb64b8bc2487d0014b2f1424a
Submitter: Zuul
Branch: stable/pike

commit fb6ff76eabdb9abeb64b8bc2487d0014b2f1424a
Author: Akihiro Motoki <email address hidden>
Date: Sat Aug 12 17:52:31 2017 +0000

    extract_messages: Specify input directory

    Currently horizon/locale/{django,djangojs}.js contain strings from
    openstack_dashboard and vice versa. To avoid this, --input-dirs
    option needs to be passed to python setup.py extract_messages.

    Change-Id: Iee874616f4c037cc68bc3b0c7d8586d86f7153f4
    Closes-Bug: #1710396
    (cherry picked from commit 19a4012b9119643a612cf5d61be5c7d8ed128a65)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 12.0.3

This issue was fixed in the openstack/horizon 12.0.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.