Incorrect stylesheet link for the serial_console template

Bug #1714311 reported by Pierre Riteau
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Pierre Riteau

Bug Description

The stylesheet referenced in openstack_dashboard/templates/serial_console.html is incorrect, as the CSS file has been changed to SCSS in I0d421d931d252d821a7ecf19a750f73b8241c249:

    <link rel="stylesheet" href="{{ STATIC_URL }}dashboard/scss/serial_console.css" type="text/css" media="screen">

Instead, the template needs to reference the SCSS file and compile it.

Pierre Riteau (priteau)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/499738

Changed in horizon:
assignee: nobody → Pierre Riteau (priteau)
status: New → In Progress
Changed in horizon:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/499738
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=7c9758dcdccc5670174b2deeb91bd20932e4d8e1
Submitter: Jenkins
Branch: master

commit 7c9758dcdccc5670174b2deeb91bd20932e4d8e1
Author: Pierre Riteau <email address hidden>
Date: Thu Aug 31 18:04:42 2017 +0100

    Fix link to serial console stylesheet

    The serial_console.css stylesheet was renamed to serial_console.scss in
    commit 09706c6e3754c218b00dcaf210629aa6970dc80a, but the link
    referencing it in the serial console template was not updated. As a
    result the serial console is displayed with a proportional font.

    This commit updates the stylesheet link and adds a compress block to
    compile it from SCSS to CSS.

    Change-Id: Ic8abc970e76cb67c79c2335370c63e235a23eb5a
    Closes-Bug: #1714311

Changed in horizon:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/pike)

Fix proposed to branch: stable/pike
Review: https://review.openstack.org/509870

Ying Zuo (yingzuo)
tags: added: pike-backport-potential
Changed in horizon:
milestone: none → queens-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/pike)

Reviewed: https://review.openstack.org/509870
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f3dfbbc127e0bfb7adeefd3df46aeaae3027fa3d
Submitter: Jenkins
Branch: stable/pike

commit f3dfbbc127e0bfb7adeefd3df46aeaae3027fa3d
Author: Pierre Riteau <email address hidden>
Date: Thu Aug 31 18:04:42 2017 +0100

    Fix link to serial console stylesheet

    The serial_console.css stylesheet was renamed to serial_console.scss in
    commit 09706c6e3754c218b00dcaf210629aa6970dc80a, but the link
    referencing it in the serial console template was not updated. As a
    result the serial console is displayed with a proportional font.

    This commit updates the stylesheet link and adds a compress block to
    compile it from SCSS to CSS.

    Change-Id: Ic8abc970e76cb67c79c2335370c63e235a23eb5a
    Closes-Bug: #1714311
    (cherry picked from commit 7c9758dcdccc5670174b2deeb91bd20932e4d8e1)

tags: added: in-stable-pike
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 13.0.0.0b1

This issue was fixed in the openstack/horizon 13.0.0.0b1 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/horizon 12.0.1

This issue was fixed in the openstack/horizon 12.0.1 release.

Akihiro Motoki (amotoki)
tags: removed: pike-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.