Juniper Openstack

LBaaSv2 API output incomplete for listener and loadbalancer objects

Bug #1733107 reported by Michel Nederlof
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R3.2
Fix Committed
High
Michel Nederlof
Juniper Openstack r3.2.8.0
R3.2.3.x
Fix Committed
High
Michel Nederlof
Juniper Openstack r3.2.3.3
R4.0
Fix Committed
High
Michel Nederlof
Juniper Openstack r4.0.3.0
R4.1
Fix Committed
High
Michel Nederlof
Juniper Openstack r4.1.1.0
Trunk
Fix Committed
High
Michel Nederlof
Juniper Openstack r5.0.0

Bug Description

1. When running 'neutron lbaas-loadbalancer-show', the listener property output is incorrect.

Currently it is like { ... , 'listener': ['<uuid>'], ...}
While it should be like { ... , 'listener': [{'id': '<uuid>'}], ... }

this causes automation tools like kubernetes and terraform to fail when cleaning up loadbancers of contrail

For example see this bug (which was fixed after changing the output like above):
https://github.com/kubernetes/kubernetes/issues/54864#issuecomment-344455078

2. When running 'neutron lbaas-loadbalancer-show', the provider attribute is not returned. If not set i'd opt to return a default provider value ('opencontrail'), which is also used when creating the a loadbalancer resource that has no provider specified.

3. In the output of 'neutron lbaas-listener-show' the field 'default_pool_id' is missing, causing the LBAASv2 horizon dashboards to render incomplete (since the reference to the pool is missing from the listener page).
I'd opt to use the first pool ref in the listener object (similar to referencing the loadbalancer).

I will provide patches for these issues.

See original description
Michel Nederlof (mnederlof)
Changed in juniperopenstack:
assignee: nobody → Michel Nederlof (mnederlof)
information type: Proprietary → Public
Michel Nederlof (mnederlof)
description: updated
description: updated
tags: added: lbaas neutron neutronapi
Michel Nederlof (mnederlof)
summary: - LBaaSv2 API output incomplete
+ LBaaSv2 API output incomplete for listener and loadbalancer objects
Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.2.3.x

Review in progress for https://review.opencontrail.org/37674
Submitter: Michel Nederlof (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/37675
Submitter: Michel Nederlof (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.2.3.x

Review in progress for https://review.opencontrail.org/37674
Submitter: Michel Nederlof (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.0

Review in progress for https://review.opencontrail.org/38246
Submitter: Yuvaraja Mariappan

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1

Review in progress for https://review.opencontrail.org/38247
Submitter: Yuvaraja Mariappan

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R3.2

Review in progress for https://review.opencontrail.org/38248
Submitter: Yuvaraja Mariappan

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/37674
Committed: http://github.com/Juniper/contrail-neutron-plugin/commit/7b142fa573166272bde680bb2b10bebaec1700c1
Submitter: Zuul (<email address hidden>)
Branch: R3.2.3.x

commit 7b142fa573166272bde680bb2b10bebaec1700c1
Author: Michel Nederlof <email address hidden>
Date: Mon Dec 11 09:50:57 2017 +0100

Fix Neutron LBaaS v2 API output

- fix loadbalancer/listener output
- include loadbalancer/provider attribute
- provide default_pool_id for listener output

Closes-bug: #1733107

Change-Id: I04da84b0694600bf3be695ad68bc20da64e7f302

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38247
Committed: http://github.com/Juniper/contrail-neutron-plugin/commit/75efc8820bc35c196f7217292c8ef157e8ac6ad3
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit 75efc8820bc35c196f7217292c8ef157e8ac6ad3
Author: Michel Nederlof <email address hidden>
Date: Mon Dec 11 09:49:26 2017 +0100

Fix Neutron LBaaS v2 API output

- fix loadbalancer/listener output
- include loadbalancer/provider attribute
- provide default_pool_id for listener output

Closes-bug: #1733107

Change-Id: I04da84b0694600bf3be695ad68bc20da64e7f302

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38246
Committed: http://github.com/Juniper/contrail-neutron-plugin/commit/7372d83300695c5351daa3aae1254c0cd61f5880
Submitter: Zuul (<email address hidden>)
Branch: R4.0

commit 7372d83300695c5351daa3aae1254c0cd61f5880
Author: Michel Nederlof <email address hidden>
Date: Mon Dec 11 09:49:26 2017 +0100

Fix Neutron LBaaS v2 API output

- fix loadbalancer/listener output
- include loadbalancer/provider attribute
- provide default_pool_id for listener output

Closes-bug: #1733107

Change-Id: I04da84b0694600bf3be695ad68bc20da64e7f302

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/38248
Committed: http://github.com/Juniper/contrail-neutron-plugin/commit/17b306b16582477fb7477a5a25d44c2d54192324
Submitter: Zuul (<email address hidden>)
Branch: R3.2

commit 17b306b16582477fb7477a5a25d44c2d54192324
Author: Michel Nederlof <email address hidden>
Date: Mon Dec 11 09:49:26 2017 +0100

Fix Neutron LBaaS v2 API output

- fix loadbalancer/listener output
- include loadbalancer/provider attribute
- provide default_pool_id for listener output

Closes-bug: #1733107

Change-Id: I04da84b0694600bf3be695ad68bc20da64e7f302

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/37675
Committed: http://github.com/Juniper/contrail-neutron-plugin/commit/fd79f99ba8227104a33128cc7c3a9e37691490e2
Submitter: Zuul (<email address hidden>)
Branch: master

commit fd79f99ba8227104a33128cc7c3a9e37691490e2
Author: Michel Nederlof <email address hidden>
Date: Mon Dec 11 09:49:26 2017 +0100

Fix Neutron LBaaS v2 API output

- fix loadbalancer/listener output
- include loadbalancer/provider attribute
- provide default_pool_id for listener output

Closes-bug: #1733107

Change-Id: I04da84b0694600bf3be695ad68bc20da64e7f302

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.