Evergreen

web client: offline not pulling working location

Bug #1736763 reported by Andrea Neiman
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned
Evergreen 3.0.3

Bug Description

3.0.x web client (tested on 3.0.0 and 3.0.1)

It appears that the Offline interface is not pulling the working location from the workstation registration, as it should be.

This will cause a failure at at least two points within Offline: registering a patron, and creating an Offline Session.

In some cases I was able to manually set the working location from the dropdown but this still caused sporadic failure for creating Offline Sessions.

Console message on create Session failure:

angular.min.js:105 GET https://demo.evergreencatalog.com/cgi-bin/offline/offline.pl?1512416186777&action=create&desc=ABN%20test&org=null&ws=BR1-abn_egdemo&wc=1&ses=3db55a2c74b556388ea98b9e6072edb3
500 (Internal Server Error)
  (anonymous) @ angular.min.js:105
  n @ angular.min.js:100
  (anonymous) @ angular.min.js:98
  (anonymous) @ angular.min.js:132
  $eval @ angular.min.js:147
  $digest @ angular.min.js:144
  $apply @ angular.min.js:147
  (anonymous) @ angular.min.js:281
  dispatch @ jquery.min.js:3
  r.handle @ jquery.min.js:3

Revision history for this message
Terran McCanna (tmccanna) wrote :

I have been seeing this issue as well. I haven't noticed it causing problems with creating sessions yet, but I have seen the patron registration form not load because of it.

Changed in evergreen:
status: New → Confirmed
Revision history for this message
Mike Rylander (mrylander) wrote :

The problem was that in the offline interface we have to wait for the org tree to be recreated from the local cache. Here's a branch that does that:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/lp-1736763-offline-working-location

tags: added: pullrequest
Revision history for this message
Andrea Neiman (aneiman) wrote :

This is working for me in light testing with multiple workstation locations, but I would appreciate if Terran or someone else could take a second look.

Changed in evergreen:
milestone: none → 3.0.3
importance: Undecided → High
Revision history for this message
Terran McCanna (tmccanna) wrote :

I tested as well with our real hierarchy and multiple workstations and it looks good to me. (My patron registration form still isn't loading, but I assume that must be a different problem. I haven't seen that problem on master.)

I have tested this code and consent to signing off on it with my name, Terran McCanna and my email address, <email address hidden>.

tags: added: signedoff
Revision history for this message
Cesar V (cesardv) wrote :

Worked for me Mike, here's a signedoff branch

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/miker_lp-1736763-offline-working-location-signoff

Revision history for this message
Mike Rylander (mrylander) wrote :

Thanks, folks. Merged to master and 3.0!

Changed in evergreen:
status: Confirmed → Fix Committed
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.