Web client: Column picker configuration fails to save in Billing History

Was checking back on bugs I've entered and have this update:
Console log lists following error when attempting to save an updated grid:

grid.js:416 Cannot save settings without a grid persist-key

I can confirm this bug as well as the column configuration not saving for Bill History Transactions and Bill History Payments.

Similar to the fix for bug 1721145, we probably just need an appropriately named persist-key in circ/patron/t_bill_history_xacts.tt2 . Note that bug 1739669 already included a persist-key for the Payments grid ("circ.patron.billhistory_payments"), which was part of Evergreen 3.0.4 (and 3.1.0).

Still seeing this in 3.1.4 and 3.1.5

3.1.5

Noting that the same console error (and failure to save any column preferences) is also seen in Bill Full Details, Payment Full Details, and Group Member Details. I can separate those into their own bugs if that makes more sense.

There is already a bug for Group Member Details: bug 1774707

This a major inconvenience for us.

Here is the very simple fix:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/rsteed/lp1739606_webstaffgrid_persistkey_bill_history_xacts

Note: to test, you will probably need to clear your browser cache.

Works for me on Bill History transactions & payments tabs. Thanks, Remington!

I have tested this code and consent to signing off on it with my name, Terran McCanna, and my email address, <email address hidden>.

It works for me! Pushed to master, rel_3_2, and rel_3_1.

Thanks, Remington, Terran, and everyone else!

I confirmed with Jason, this needs an upgrade script (add this persist key to config.workstation_setting_type) because of the change to server-side settings. Thanks to Michele Morgan for the tip (see https://bugs.launchpad.net/evergreen/+bug/1729435/comments/5).

I created bug 1806709 for the needed upgrade script, and marked it with High importance for inclusion in 3.2.3, in hopes that we can get both halves of the fix into the same release.