Evergreen

Web Client: Print Current Bills only prints circ not grocery

Bug #1742194 reported by Terran McCanna
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned
Evergreen 3.0.3

Bug Description

In 3.0.2:

Printing current bills (Patron Account > Bills > Actions > Print Bills) only prints circulation bills, not grocery bills.

This was working properly in 3.0.0 - not sure if it broke in 3.0.1 or 3.0.2.

Revision history for this message
Blake GH (bmagic) wrote :

Confirmed on our 3.0.2 production.

Kathy Lussier (klussier)
Changed in evergreen:
status: New → Confirmed
Terran McCanna (tmccanna)
Changed in evergreen:
importance: Undecided → Medium
Revision history for this message
Terran McCanna (tmccanna) wrote :

This is also broken when printing using Bills > History.

My best guess is that it broke with this patch to bills.js, but I don't understand the changes well enough to troubleshoot any further than that:

https://bugs.launchpad.net/evergreen/+bug/1708487

Kyle Huckins (khuckins)
Changed in evergreen:
assignee: nobody → Kyle Huckins (khuckins)
Revision history for this message
Kyle Huckins (khuckins) wrote :

Thanks for the heads up on this Terran, this was related to that patch - the web client was complaining that it couldn't find target_copy() of undefined - I could have sworn this would just default to null if it couldn't find that value. I've added a check for an existing circulation on the bill before assigning circulation data to newXact, and tested it with gorcery and circulation bills - everything looks good on my end.

Branch here: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1742194-print-current-bills-printing-only-grocery

tags: added: pullrequest
Changed in evergreen:
assignee: Kyle Huckins (khuckins) → nobody
Revision history for this message
Terran McCanna (tmccanna) wrote :

khuckins++ Will test now!

Revision history for this message
Terran McCanna (tmccanna) wrote :

Works like a charm!

I have tested this code and consent to signing off on it with my name, Terran McCanna, and my email address, <email address hidden>.

tags: added: signedoff
Galen Charlton (gmc)
tags: added: regression
Revision history for this message
Galen Charlton (gmc) wrote :

Pushed to master and rel_3_0. Thanks, Kyle and Terran!

Changed in evergreen:
milestone: none → 3.0.3
status: Confirmed → Fix Committed
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.