Juniper Openstack

During contrail-control shutdown, disable uve timer before its deletion

Bug #1756791 reported by Ananth Suryanarayana
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Juniper Openstack
Status tracked in Trunk
R4.0
Fix Committed
High
Ananth Suryanarayana
Juniper Openstack r4.0.3.0
R4.1
Fix Committed
High
Ananth Suryanarayana
Juniper Openstack r4.1.1.0
Trunk
Fix Committed
High
Ananth Suryanarayana
Juniper Openstack r5.0.0

Bug Description

During contrail-control shutdown process, node_info_log_timer is directly deleted from main thread. This can process to crash if the timer happens to be running or scheduled to fire at exactly the same time (from other threads).

Fix by first disabling the timer and then wait till the timer gets fully cancelled before proceeding ahead with the deletion of the timer.

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] master

Review in progress for https://review.opencontrail.org/40787
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.1

Review in progress for https://review.opencontrail.org/40789
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : [Review update] R4.0

Review in progress for https://review.opencontrail.org/40790
Submitter: Ananth Suryanarayana (<email address hidden>)

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote : A change has been merged

Reviewed: https://review.opencontrail.org/40790
Committed: http://github.com/Juniper/contrail-controller/commit/5f6cb940282018a3682c29a5e8ac4c9355e8f0af
Submitter: Zuul (<email address hidden>)
Branch: R4.0

commit 5f6cb940282018a3682c29a5e8ac4c9355e8f0af
Author: Ananth Suryanarayana <email address hidden>
Date: Sun Mar 18 22:07:48 2018 -0700

During contrail-control shutdown, disable node_info timer before its deletion

During contrail-control shutdown process, node_info_log_timer is directly
deleted from main thread. This can process to crash if the timer happens to
be running or scheduled to fire at exactly the same time (from other threads).

Fix by first disabling the timer and then wait till the timer gets fully
cancelled before proceeding ahead with the deletion of the timer.

Found and verified the fix using bgp_stress_test

Change-Id: Ia9909164d7f41074b6a38f48d332a0cc7b040ea1
Closes-Bug: 1756791

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/40789
Committed: http://github.com/Juniper/contrail-controller/commit/03a927e19171bc935df5c4acd737e9e5ebaa2618
Submitter: Zuul (<email address hidden>)
Branch: R4.1

commit 03a927e19171bc935df5c4acd737e9e5ebaa2618
Author: Ananth Suryanarayana <email address hidden>
Date: Sun Mar 18 22:07:48 2018 -0700

During contrail-control shutdown, disable node_info timer before its deletion

During contrail-control shutdown process, node_info_log_timer is directly
deleted from main thread. This can process to crash if the timer happens to
be running or scheduled to fire at exactly the same time (from other threads).

Fix by first disabling the timer and then wait till the timer gets fully
cancelled before proceeding ahead with the deletion of the timer.

Found and verified the fix using bgp_stress_test

Change-Id: Ia9909164d7f41074b6a38f48d332a0cc7b040ea1
Closes-Bug: 1756791

Revision history for this message
OpenContrail Admin (ci-admin-f) wrote :

Reviewed: https://review.opencontrail.org/40787
Committed: http://github.com/Juniper/contrail-controller/commit/e99e539e335d28b2da1d00b795d6368738cb36cf
Submitter: Zuul v3 CI (<email address hidden>)
Branch: master

commit e99e539e335d28b2da1d00b795d6368738cb36cf
Author: Ananth Suryanarayana <email address hidden>
Date: Sun Mar 18 22:07:48 2018 -0700

During contrail-control shutdown, disable node_info timer before its deletion

During contrail-control shutdown process, node_info_log_timer is directly
deleted from main thread. This can process to crash if the timer happens to
be running or scheduled to fire at exactly the same time (from other threads).

Fix by first disabling the timer and then wait till the timer gets fully
cancelled before proceeding ahead with the deletion of the timer.

Found and verified the fix using bgp_stress_test

Change-Id: Ia9909164d7f41074b6a38f48d332a0cc7b040ea1
Closes-Bug: 1756791

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.