tripleo

Hieradata is not populate correctly with the parameters under service_config_settings

Bug #1757066 reported by Juan Badia Payno
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Medium
Juan Badia Payno
tripleo rocky-1

Bug Description

Parameters defined on /puppet/services/XXXX.yaml under the service_config_settings tag are not set properly into the hieradata.

How to reproduce
================
1.- Install the undercloud with tripleo-quickstart (1 compute-1 controller)
2.- Clone the tht on the undercloud
3.- Modify the overcloud-deploy script to use the master branch
4.- Add fluentd and collectd docker services to deploy
   -e tripleo-heat-templates/environments/services-docker/collectd.yaml \
   -e tripleo-heat-templates/environments/services-docker/fluentd.yaml \
   -e params.yaml

cat ~/params.yaml
---
parameter_defaults:
  LoggingServers:
    - host: 192.168.1.52
      port: 24224
  CollectdServer: 192.168.1.52
  CollectdSecurityLevel: None

5.- Log in into the novacompute host and check that the parameters defined at
https://github.com/openstack/tripleo-heat-templates/blob/master/puppet/services/nova-compute.yaml#L242 are not on the hieradata
  grep tripleo_fluentd_groups_nova_compute /etc/puppet/hieradata/*
  grep tripleo_fluentd_groups_nova_compute /var/lib/config-data/fluentd/etc/puppet/hieradata/*

  grep collectd::plugin::virt::connection /etc/puppet/hieradata/*
  grep tripleo.collectd.plugins.nova_compute /var/lib/config-data/collectd/etc/puppet/hieradata/*

Revision history for this message
Steven Hardy (shardy) wrote :

I think this is because the docker/services nova-compute template is missing service_config_settings:

https://github.com/openstack/tripleo-heat-templates/blob/master/docker/services/nova-compute.yaml#L107

It should reference the service_config_settings from the NovaBase resource?

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.openstack.org/554596

Changed in tripleo:
assignee: nobody → Juan Badia Payno (jbadiapa)
status: New → In Progress
Emilien Macchi (emilienm)
Changed in tripleo:
milestone: none → rocky-1
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on tripleo-heat-templates (master)

Change abandoned by Emilien Macchi (<email address hidden>) on branch: master
Review: https://review.openstack.org/554596
Reason: clear up the gate to merge CI blockers, I'll restore the patches.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/554596
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=a3297afea9fd03c495c280cac881218032786355
Submitter: Zuul
Branch: master

commit a3297afea9fd03c495c280cac881218032786355
Author: Juan Badia Payno <email address hidden>
Date: Tue Mar 20 16:28:14 2018 +0100

    Add the service_config_settings from nova-compute base

    The docker nova-compute.yaml file does not have the
    service_config_settings from the base file. So the
    collectd and fluentd parameters defined are not got
    when the service run containerized.

    The patch get the service_config_settings from the base file and
    use it on the when is containerized.

    Closes-Bug: #1757066
    Change-Id: I0b3567edd7530d1ae0a69d3ee25bd1442f14fb58

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/561202

Bogdan Dobrelya (bogdando)
tags: added: queens-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/561202
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=51269a1e22793d858dca56fd7f362efc2c387f55
Submitter: Zuul
Branch: master

commit 51269a1e22793d858dca56fd7f362efc2c387f55
Author: Juan Badia Payno <email address hidden>
Date: Fri Apr 13 13:40:43 2018 +0200

    Add the service_config_settings from {{service-name}} base

    Some container yaml file does not get the
    service_config_settings from the base file.

    This patch makes for the following docker yaml files get
    the service_config_settings:
     docker/services/neutron-l3.yaml
     docker/services/neutron-metadata.yaml
     docker/services/neutron-ovs-agent.yaml

    Related-Bug: #1757066

    Change-Id: Ifc8def10da0b10decd12efaab4452ff46f3c685b

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 9.0.0.0b2

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b2 development milestone.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/563554

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to tripleo-heat-templates (stable/queens)

Related fix proposed to branch: stable/queens
Review: https://review.openstack.org/563556

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to tripleo-heat-templates (stable/queens)

Reviewed: https://review.openstack.org/563556
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=beb9fa835f3f589dd5a87965727190f4a1be20d8
Submitter: Zuul
Branch: stable/queens

commit beb9fa835f3f589dd5a87965727190f4a1be20d8
Author: Juan Badia Payno <email address hidden>
Date: Fri Apr 13 13:40:43 2018 +0200

    Add the service_config_settings from {{service-name}} base

    Some container yaml file does not get the
    service_config_settings from the base file.

    This patch makes for the following docker yaml files get
    the service_config_settings:
     docker/services/neutron-l3.yaml
     docker/services/neutron-metadata.yaml
     docker/services/neutron-ovs-agent.yaml

    Related-Bug: #1757066

    Change-Id: Ifc8def10da0b10decd12efaab4452ff46f3c685b
    (cherry picked from commit 51269a1e22793d858dca56fd7f362efc2c387f55)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/queens)

Reviewed: https://review.openstack.org/563554
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=b42cd09f8469396e1219bf37f50a45f878f91985
Submitter: Zuul
Branch: stable/queens

commit b42cd09f8469396e1219bf37f50a45f878f91985
Author: Juan Badia Payno <email address hidden>
Date: Tue Mar 20 16:28:14 2018 +0100

    Add the service_config_settings from nova-compute base

    The docker nova-compute.yaml file does not have the
    service_config_settings from the base file. So the
    collectd and fluentd parameters defined are not got
    when the service run containerized.

    The patch get the service_config_settings from the base file and
    use it on the when is containerized.

    Closes-Bug: #1757066
    Change-Id: I0b3567edd7530d1ae0a69d3ee25bd1442f14fb58
    (cherry picked from commit a3297afea9fd03c495c280cac881218032786355)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 8.0.3

This issue was fixed in the openstack/tripleo-heat-templates 8.0.3 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.