FFU upgrade failure on panko db sync.

The panko task has been introduced recently[1], but something is missing to have this working.

[1] https://review.openstack.org/#/c/557675/2/docker/services/panko-api.yaml

Error message is not really helping[1]

2018-03-30 14:24:24.586 198767 WARNING oslo_reports.guru_meditation_report [-] Guru meditation now registers SIGUSR1 and SIGUSR2 by default for backward compatibility. SIGUSR1 will no longer be registered in a future release, so please use SIGUSR2 to generate reports.
2018-03-30 14:25:54.648 198767 CRITICAL panko [-] RetryError: RetryError[<Future at 0x319ed90 state=finished raised AttributeError>]
2018-03-30 14:25:54.648 198767 ERROR panko Traceback (most recent call last):
2018-03-30 14:25:54.648 198767 ERROR panko File "/bin/panko-dbsync", line 10, in <module>
2018-03-30 14:25:54.648 198767 ERROR panko sys.exit(dbsync())
2018-03-30 14:25:54.648 198767 ERROR panko File "/usr/lib/python2.7/site-packages/panko/cmd/storage.py", line 29, in dbsync
2018-03-30 14:25:54.648 198767 ERROR panko storage.get_connection_from_config(conf).upgrade()
2018-03-30 14:25:54.648 198767 ERROR panko File "/usr/lib/python2.7/site-packages/panko/storage/__init__.py", line 73, in get_connection_from_config
2018-03-30 14:25:54.648 198767 ERROR panko return _inner()
2018-03-30 14:25:54.648 198767 ERROR panko File "/usr/lib/python2.7/site-packages/tenacity/__init__.py", line 87, in wrapped_f
2018-03-30 14:25:54.648 198767 ERROR panko return r.call(f, *args, **kw)
2018-03-30 14:25:54.648 198767 ERROR panko File "/usr/lib/python2.7/site-packages/tenacity/__init__.py", line 189, in call
2018-03-30 14:25:54.648 198767 ERROR panko six.raise_from(RetryError(fut), fut.exception())
2018-03-30 14:25:54.648 198767 ERROR panko File "/usr/lib/python2.7/site-packages/six.py", line 718, in raise_from
2018-03-30 14:25:54.648 198767 ERROR panko raise value
2018-03-30 14:25:54.648 198767 ERROR panko RetryError: RetryError[<Future at 0x319ed90 state=finished raised AttributeError>]
2018-03-30 14:25:54.648 198767 ERROR panko

[1] https://logs.rdoproject.org/26/557926/1/openstack-check/gate-tripleo-ci-centos-7-multinode-1ctlr-featureset036-oc-ffu-queens-nv/Z4e7463e2389c42d598721303f1620c16/subnode-2/var/log/panko/panko-dbsync.log.txt.gz

Oki, so root cause here is that panko is not configured[1]. The connection not defined at all.

This is because as a new package we it's hasn't had a chance to be properly configured by puppet.

[1] https://logs.rdoproject.org/26/557926/1/openstack-check/gate-tripleo-ci-centos-7-multinode-1ctlr-featureset036-oc-ffu-queens-nv/Z4e7463e2389c42d598721303f1620c16/subnode-2/etc/panko/panko.conf.txt.gz

Panko variables are not set at all in the hieradata.

We basically miss everything from[1], which is expected as we didn't re-run a hook to get those data.

By the look of [1] we not only miss panko config but mysql db altogether as it's seems to be created at that moment.

I think we should revert the patch, and get panko installed in the last step, can't see why we should should upgrade that newly created db.

[1] https://github.com/openstack/tripleo-heat-templates/blob/stable/ocata/puppet/services/panko-base.yaml#L39..L75

Related fix proposed to branch: master
Review: https://review.openstack.org/557953

Related fix proposed to branch: stable/queens
Review: https://review.openstack.org/557954

Reviewed: https://review.openstack.org/557953
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=f3d340fea7f484b893d880b7ee6c876a5c219089
Submitter: Zuul
Branch: master

commit f3d340fea7f484b893d880b7ee6c876a5c219089
Author: Athlan-Guyot sofer <email address hidden>
Date: Fri Mar 30 15:59:06 2018 +0000

    Revert "FFU: Add support for panko service upgrade"

    This reverts commit bd48087520c5f0846363bdc0c025508ba450ceb3.

    After further inspection It seems that panko dbsync shouldn't be
    needed, as it will upgrade an newly created empty db.

    And this is assuming we find a way to:
     - configure panko database connection properly
     - create the db

    Knowing that we don't have access to this information[1] as the
    new hieradata haven't been rendered at this stage.

    So all that to upgrade a newly (I guess empty) database seems like too
    much trouble.

    The db will be created in the last step of the FFU.

    [1] https://github.com/openstack/tripleo-heat-templates/blob/stable/ocata/puppet/services/panko-base.yaml#L39..L75

    Change-Id: Ie68849a7033c199c339d28cdb10c3dba9419904b
    Closes-Bug: #1760135

Reviewed: https://review.openstack.org/557954
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=324646db10e6f7aad901e0efe15937cf5464ebb6
Submitter: Zuul
Branch: stable/queens

commit 324646db10e6f7aad901e0efe15937cf5464ebb6
Author: Athlan-Guyot sofer <email address hidden>
Date: Fri Mar 30 15:59:06 2018 +0000

    Revert "FFU: Add support for panko service upgrade"

    This reverts commit bd48087520c5f0846363bdc0c025508ba450ceb3.

    After further inspection It seems that panko dbsync shouldn't be
    needed, as it will upgrade an newly created empty db.

    And this is assuming we find a way to:
     - configure panko database connection properly
     - create the db

    Knowing that we don't have access to this information[1] as the
    new hieradata haven't been rendered at this stage.

    So all that to upgrade a newly (I guess empty) database seems like too
    much trouble.

    The db will be created in the last step of the FFU.

    [1] https://github.com/openstack/tripleo-heat-templates/blob/stable/ocata/puppet/services/panko-base.yaml#L39..L75

    Change-Id: Ie68849a7033c199c339d28cdb10c3dba9419904b
    Closes-Bug: #1760135
    (cherry picked from commit f3d340fea7f484b893d880b7ee6c876a5c219089)

This issue was fixed in the openstack/tripleo-heat-templates 9.0.0.0b2 development milestone.

This issue was fixed in the openstack/tripleo-heat-templates 8.0.2 release.