Wishlist: allow different styling for search bar on home page

Bug #1760160 reported by Jane Sandberg
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Wishlist
Unassigned

Bug Description

Libraries may wish for the search bar to be styled differently on the home page than in search results, etc. For example, we're interested in having a large, inviting search bar on the home page, and a smaller one in search results pages.

I'm going to put together a branch that adds some special CSS classes to the search bar and submit button when they appear on the home page.

Revision history for this message
Jane Sandberg (sandbergja) wrote :

I created a branch called user/sandbergja/lp1760160_different_css_classes_for_search_bar_on_home_page

Here's a link: http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1760160_different_css_classes_for_search_bar_on_home_page

tags: added: pullrequest
Changed in evergreen:
assignee: Jane Sandberg (sandbej) → nobody
Galen Charlton (gmc)
Changed in evergreen:
importance: Undecided → Wishlist
status: New → Confirmed
milestone: none → 3.2-beta
Revision history for this message
Galen Charlton (gmc) wrote :

I took a look at this, and agree that being able to adjust the style of the search bar based on whether or not the user is at the home page is a good idea. However, I have a suggestion: rather than defining separate styles for the input and the submit button, how about instead having it add a searchbar-home (or whatever) class to the div enclosing the entire search bar? That would open up more options for styling every child element without needing to add more classes.

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks for taking a look, Galen, and for the helpful feedback. I like your idea better; it's a simpler change, too. I updated my branch to use your approach instead.

Revision history for this message
Jane Sandberg (sandbergja) wrote :

On that same branch, I added some release notes and documentation.

Revision history for this message
Bill Erickson (berick) wrote :

Confirmed the patch has no impact by default, but a giant purple search box appears when adding the test/sample CSS.

Thanks, Jane! Merged to master.

Changed in evergreen:
status: Confirmed → Fix Committed
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.