Limit API lacks abstraction for enforcement models
Bug #1768572 reported by
Lance Bragstad
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenStack Identity (keystone) |
Fix Released
|
Medium
|
wangxiyuan | ||
Bug Description
The unified limits API introduced in Queens implemented a single enforcement model called "flat". Since "flat" was the initial enforcement model implementation, it was tightly coupled with the rest of the logic for the limit API [0].
In the future, we plan to make enforcement models configurable so that deployments can choose how they want limit enforcement to behave across projects. This will be easier to do if we decouple the enforcement model from the actual limit CRUD. The limit API will become simpler because its won't have to worry about different characteristics of various enforcement models. Instead, that logic can be encapsulated into a single object, making it the sole responsibility of that object.
| Changed in keystone: | |
| importance: | Undecided → Medium |
| status: | New → Triaged |
| tags: | added: limits |
Revision history for this message
| OpenStack Infra (hudson-openstack) wrote Related fix merged to keystone (master) | #1 |
Revision history for this message
| Lance Bragstad (lbragstad) wrote | #2 |
| Changed in keystone: | |
| assignee: | nobody → wangxiyuan (wangxiyuan) |
| status: | Triaged → Fix Committed |
| Changed in keystone: | |
| status: | Fix Committed → Fix Released |
| Changed in keystone: | |
| milestone: | none → rocky-3 |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit fd4b7371338d9a7
Author: Lance Bragstad <email address hidden>
Date: Thu Apr 19 15:22:50 2018 +0000
Implement enforcement model logic in Manager
This commit adds the necessary bits to return the enforcement model
used by a deployment in the limit Manager. A subsequent patch will
expose this functionality via the API.
This commit also starts introdcuing the concept of enforcement
models and puts the flat model into its own module. This will make
more sense and be easier to maintain as we implement more models.
Change-Id: I32227eb0023e6b
Related-Bug: 1765193
Related-Bug: 1768572