Improvements to Patron Acquisition Request

AngularJS? Or Angular?

We are shipping this with AngularJS since this development was contracted, spec'd, and 90% code-complete before the official community decision to migrate away from AngularJS. There is a possibility that it can be updated as part of the general conversion of Acquisitions to Angular, and I've made a note to explore this during the spec phase of that project.

Does this work include updating the documentation?

Yes, we will be including updated documentation for the new interfaces.

collab/phasefx/acq_requests_rebased @ working/Evergreen.git

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/acq_requests_rebased

The unsquashed and un-rebased original can be found at collab/phasefx/acq_requests

I'll come back with a test plan and actual code tests :)

Force pushed a branch with a live_t/ test that exercises a specific Acquisition workflow.

For manual testing, this can get you started (assuming Concerto test data):

Login to the web client with a BR1 Acquisitions user at a BR1 workstation.

Go to Acquisitions -> Patron Requests

Click "Create Request"

In the "User Barcode" field, enter: 99999303411

In the "Request Type" field, choose "Books"

In the "Title" field, enter: test

Click "Save" at the bottom

Select the new row

Go to Actions -> Add Request to Seletion List

In the field "Add to Selection List", enter: test

Click "Save Record"

Select the row again

Go to Actions -> View Selection List

In the "Estimated Price" field, enter: 1

Select the checkbox for the Line Item.

In the "Copies" field, enter: 1

In the "Owning Branch" field, choose "BR1"

In the "Copy Location" field, choose "Audio/Video (BR1)"

In the "Fund" field, chosoe "AD (2018)"

Click "Apply to Selected"

Scroll the screen back to the top

In the drop-down menu that displays "--Actions--", choose "Create Purchase Order"

In the "Ordering Agency" field, choose "BR1"

In the "Name (optional)" field, enter: test

In the "Provider" field, enter: BRODART

Click "Submit"

Click "Activate Order"

In the field "Or create a new queue", enter: test

Make sure the "Import Non-Matching Records" option is checked.

Click "Submit"

Scroll the screen to the top

In the Line Items area, click "requests"

You should be back at the Acquisition Patron Requests interface, but with the PO Line Item ID referenced where the Pickup Library menu used to be. The Request Status for the user request should show "Ordered, Hold Not Placed".

Select the row

Go to Actions -> Cancel Requests

In the "Cancel Reason" field, choose "Canceled: Fulfilled"

Click "Cancel Requests"

The row should no longer be visible.

Click "Show Canceled Requests"

The row should be visible.

"where the Pickup Library menu used to be"

should be

"where the Patron Home Library menu used to be"

Thanks Jane, I've added an extra commit to the branch with some release notes. Is there any general guidance for writing such other than trying to mimic what's there?

Thanks for asking, Jason. There is some guidance for release note entries here: https://wiki.evergreen-ils.org/doku.php?id=contributing:release_notes

Your release note looks good to me!

Documentation PR'd here: https://github.com/evergreen-library-system/Evergreen/pull/62

Noting that this was tested by staff from PaILS and Evergreen Indiana as part of Equinox's internal testing period. Internal testing was completed with all identified bugs resolved prior to the community pull request.

Stepped through a number of scenarios. Looks good. These are great additions. Thanks, All! Merged to master.