Web Client: Holds Pull List labeled as Holds Shelf on tab

Screenshot of the two screens.

I noticed this also, but hadn't made it over to Launchpad yet. Marking Confirmed.

This is an interesting case, since the Holds Pull List and Holds Shelf are part of the same AngularJS "app" (or "module"). The Holds template sets ctx.page_title to "Holds Shelf", but then the URL determines which controller and interface are used.

We seem to already have a mechanism for changing the page title dynamically, via egCore.strings.setPageTitle() (for an example, see staff/circ/patron/app.js), but I can't tell if that's the "right" approach for this case, since the "egCore.strings" service seems intended for use with translations. But if you called egCore.strings.setPageTitle() somewhere within HoldsPullListCtrl, I think it would work.

Still an issue in 3.3

Remington, thanks for the notes. Here is a branch that implements changing the Pull List title. I added a egCore.strings value for 'Pull List' so a properly translated string will get added.

Working Branch at: user/stompro/lp1774285_pull_list_page_title

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/stompro/lp1774285_pull_list_page_title

Josh

I have tested this code and consent to signing off with my name, Jessica Woolford, and email, <email address hidden>

Thanks for this, Josh and Jessica. It works well, and I pushed it to master and rel_3_4.

I also threw in a small follow-up commit to make the page title consistent with the header at the top of the page.