cluster_series_upgrading always true even if it's false
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
percona-cluster (Juju Charms Collection) |
Invalid
|
Undecided
|
Unassigned |
Bug Description
With the 18.11 release, the introduction of the following code causes the condition to always be true:
cluster_
if cluster_
leader = (leader_
leader_ip = leader_
else:
leader = is_leader()
leader_ip = leader_
I couldn't find anything in the post-series-upgrade hook which un-sets cluster_
(Pdb) leader_
u'False'
Because that's a string, cluster_
(Pdb) leader_
u'10.28.2.194'
(Pdb) leader_
u'10.28.2.45'
So the leader ends up thinking it's not the leader and bad things happen.
For both percona-cluster [0] and rabbitmq-server there is a complete- cluster- series- upgrade action which clears this value. It is mentioned in the documentation [1] but it is easy to miss.
We will consider ways to make this more efficient. But for now this is addressed in the action on purpose.
[0] https:/ /github. com/openstack/ charm-percona- cluster/ blob/master/ actions. yaml#L20 /docs.openstack .org/project- deploy- guide/charm- deployment- guide/latest/ app-series- upgrade. html
[1] https:/