YAOUS for when no 856$z is present

Branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=bddee32638c4502abcec395fc5b48cabc78db6d6

rogan/lp1812241_nosubfieldz

Thanks for this branch, Rogan. I signed off on it, and added a follow up commit based on our IRC conversation.

user/sandbergja/lp1812241_nosubfieldz

Looks like something has changed in master since this was done as it's not patching cleanly for me.

summary.tt2 has had changes and doesn't match the diff anymore. Some of the code removed by the patch is already removed and others changed. So, I'm going to remove the pull request tag and mark this for rebasing.

I rebased Rogan's commit, and re-did mine: user/sandbergja/lp1812241_nosubfieldz-2

Some testing notes:

1. Create two records with located URIs (e.g. with 856 40 $9 CONS).
2. Give one of the records a note in 856$z
3. In the Library Settings Editor, set a value for "Default text to appear for 856 links if none is present" for your OPAC's org unit or higher.
4. Confirm that the record with the 856$z still uses the 856$z text as the link note text in the record page.
5. Confirm that the record with the 856$z still uses the 856$z text as the link note text in the search results ("show more details" needs to be on for it to display).
6. Confirm that the record without an 856$z uses the text you entered in the Library Settings Editor as the note, in both the record view and the search results page (again, with "Show More Details" turned on).

Testing on https://terran-main.gapines.org/ and following Jane's testing step, this works as described, so I am willing to sign off on this as it is a nice feature.

I would like to note, however, that, to be consistent with the opac, this note should display in the staff catalog as well.

I have tested this code and consent to signing off on it with my name,
Christine Morgan and my email address,
<email address hidden>.

Christine - do you think that the OPAC-display should be added as a new bug and this should go ahead and be committed to main as-is, or do you think it warrants waiting to commit this until the OPAC display is included?

I think this should go ahead and be committed to main as is and a new bug should be opened for the angualar staff catalog.

Thanks Terran!

Added follow up bug report: https://bugs.launchpad.net/evergreen/+bug/2043120

Thanks all!

Fix committed to 3.12 by Jane Sandberg and Terran McCann