tripleo

UpgradeInitCommand not applying at correct time

Bug #1812659 reported by Jiří Stránský on 2019-01-21

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	High	Carlos Camacho	tripleo stein-3

Bug Description

After switching to config download, UpgradeInitCommand and UpgradeInitCommonCommand apply after upgrade playbook, at the beginning of deploy playbook. This means that if they are used to switch repositories, the command will be executed too late -- yum update is executed in upgrade playbook.

Tags:

OpenStack Infra (hudson-openstack) on 2019-01-21

Changed in tripleo:
assignee:	nobody → Carlos Camacho (ccamacho)
status:	Triaged → In Progress

Revision history for this message

Carlos Camacho (ccamacho) wrote on 2019-01-21:

Fix proposed: https://review.openstack.org/#/c/632108

Carlos Camacho (ccamacho) on 2019-01-24

tags:

added: queens-backport-potential rocky-backport-potential

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-02-01: Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.openstack.org/632108
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=9164e6adbdce69a2b7c10e1aea6c5cb309b6754e
Submitter: Zuul
Branch: master

commit 9164e6adbdce69a2b7c10e1aea6c5cb309b6754e
Author: Carlos Camacho <email address hidden>
Date: Mon Jan 21 16:05:58 2019 +0100

Move UpgradeInitCommand and UpgradeInitCommonCommand to run by Ansible

    This change moves the execution of UpgradeInitCommand
    and UpgradeInitCommonCommand to be executed with
    Ansible in the upgrade step 0 instead of Heat.

Closes-bug: 1812659
Change-Id: I76eb6a2572e24b6f114e38897a68cd85276af3c6

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-02-04: Fix proposed to tripleo-heat-templates (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/634650

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-02-05: Fix proposed to tripleo-heat-templates (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/634892

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-02-05: Fix merged to tripleo-heat-templates (stable/rocky)

Reviewed: https://review.openstack.org/634650
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=5753352ee7e600f30a67a196c3c8b3d06493257e
Submitter: Zuul
Branch: stable/rocky

commit 5753352ee7e600f30a67a196c3c8b3d06493257e
Author: Carlos Camacho <email address hidden>
Date: Mon Jan 21 16:05:58 2019 +0100

Move UpgradeInitCommand and UpgradeInitCommonCommand to run by Ansible

    This change moves the execution of UpgradeInitCommand
    and UpgradeInitCommonCommand to be executed with
    Ansible in the upgrade step 0 instead of Heat.

    Closes-bug: 1812659
    Change-Id: I76eb6a2572e24b6f114e38897a68cd85276af3c6
    (cherry picked from commit 9164e6adbdce69a2b7c10e1aea6c5cb309b6754e)

tags:

added: in-stable-rocky

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-02-07: Fix proposed to tripleo-heat-templates (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.openstack.org/635450

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-02-07: Fix proposed to tripleo-heat-templates (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.openstack.org/635452

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-02-07: Fix merged to tripleo-heat-templates (stable/queens)

Reviewed: https://review.openstack.org/634892
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=52be3ef9c15a2be05f59b97653530ff3ca2e4786
Submitter: Zuul
Branch: stable/queens

commit 52be3ef9c15a2be05f59b97653530ff3ca2e4786
Author: Carlos Camacho <email address hidden>
Date: Mon Jan 21 16:05:58 2019 +0100

Move UpgradeInitCommand and UpgradeInitCommonCommand to run by Ansible

    This change moves the execution of UpgradeInitCommand
    and UpgradeInitCommonCommand to be executed with
    Ansible in the upgrade step 0 instead of Heat.

    Closes-bug: 1812659
    Change-Id: I76eb6a2572e24b6f114e38897a68cd85276af3c6
    (cherry picked from commit 9164e6adbdce69a2b7c10e1aea6c5cb309b6754e)
    (cherry picked from commit 5753352ee7e600f30a67a196c3c8b3d06493257e)

tags:

added: in-stable-queens

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-02-07: Fix merged to tripleo-heat-templates (stable/rocky)

Reviewed: https://review.openstack.org/635450
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=5a4431d0a044074614a3f313c3f54b371103a59f
Submitter: Zuul
Branch: stable/rocky

commit 5a4431d0a044074614a3f313c3f54b371103a59f
Author: Carlos Camacho <email address hidden>
Date: Wed Feb 6 12:22:04 2019 +0100

Adding dependency for NetworkDeployment in 'server_resource_name'Deployment

    We removed the dependency for NetworkDeployment[1] in
    role.role.j2.yaml after moving to Ansible the
    UpgradeInitCommand and UpgradeInitCommonCommand Heat hooks.

[1]: https://review.openstack.org/#/c/632108/17/puppet/role.role.j2.yaml@649

    Closes-bug: 1812659
    Change-Id: I2dae3358b56946aaae7eddbf3eb501e672455565
    (cherry picked from commit aa2dc674fb3abdf4d5d2f1d41cc964cc32137b3c)

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-02-07: Fix merged to tripleo-heat-templates (stable/queens)

#10

Reviewed: https://review.openstack.org/635452
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=6323aa38c9e93a5fd2e0d6d83fb823500d47f7be
Submitter: Zuul
Branch: stable/queens

commit 6323aa38c9e93a5fd2e0d6d83fb823500d47f7be
Author: Carlos Camacho <email address hidden>
Date: Wed Feb 6 12:22:04 2019 +0100

Adding dependency for NetworkDeployment in 'server_resource_name'Deployment

    We removed the dependency for NetworkDeployment[1] in
    role.role.j2.yaml after moving to Ansible the
    UpgradeInitCommand and UpgradeInitCommonCommand Heat hooks.

[1]: https://review.openstack.org/#/c/632108/17/puppet/role.role.j2.yaml@649

    Closes-bug: 1812659
    Change-Id: I2dae3358b56946aaae7eddbf3eb501e672455565
    (cherry picked from commit aa2dc674fb3abdf4d5d2f1d41cc964cc32137b3c)
    (cherry picked from commit 5a4431d0a044074614a3f313c3f54b371103a59f)