If the user fails to include their network-isolation or network environment files when performing a stack update, it will fail when Heat attempts to create the default flat network in the overcloud configuration. This is a very destructive action as recovery from this condition requires that a user restore their undercloud database from a backup or manually remove the resources created.
How to reproduce the problem:
1) Deploy the cloud
openstack overcloud deploy --templates -e /usr/share/openstack-tripleo-heat-templates/environments/enable-swap.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/network-isolation.yaml -e /usr/share/openstack-tripleo-heat-templates/environments/network-environment.yaml -e /home/centos/container-defaults.yaml -e /home/centos/params.yaml
2) Run an update without network-isolation.yaml
openstack overcloud deploy --templates -e /usr/share/openstack-tripleo-heat-templates/environments/enable-swap.yaml -e /home/centos/container-defaults.yaml -e /home/centos/params.yaml
Reviewed: https:/
Committed: https:/
Submitter: Zuul
Branch: master
commit 1a71c441fa89588
Author: Alex Schultz <email address hidden>
Date: Sat Feb 23 12:54:23 2019 -0700
Check that the networks are defined on update
Check defined networks in the resource registry of the stack against the
networks defined in the environment files. If the environment provided
doesn't have the networks defined, it's likely they were improperly
dropped which can lead to deployment issues. This is a light check that
only checks for the existance of the networks but not the contents of
those networks. This handles the case where a user forgets to include
the network-isolation configuration on a subsequent update to the cloud.
This does not prevent a user from changing the contents of the networks
to something that breaks their deployment.
Partial-Bug: #1817631
Change-Id: Ia97a2367770e37