tripleo

Upgrading from rocky to stein/master does not verify the neutron mechanism correctly

Bug #1823042 reported by Jose Luis Franco on 2019-04-03

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	High	Kamil Sambor	tripleo stein-rc1

Bug Description

When upgrading from a OVS deployment in Rocky to Master/Stein the process shouldn't continue if OVS is not being enabled in version we are upgrading to. The idea is to upgrade from OVS to OVS, and subsequently migrate to OVN once the upgrade has succeeded. With the intention of avoiding that further issues would arise a check was included in tripleo-common https://review.openstack.org/#/c/625341/6 however, that's not catching it when we upgrade missing to enable OVS services:

Services enabled during deployment: http://logs.openstack.org/34/649434/2/check/tripleo-ci-centos-7-standalone-upgrade/8fb7ea9/logs/undercloud/home/zuul/undercloud-ansible-Q9UaDM/Standalone/service_names.yaml.txt.gz

Services enabled for the upgrade: http://logs.openstack.org/34/649434/2/check/tripleo-ci-centos-7-standalone-upgrade/8fb7ea9/logs/undercloud/home/zuul/undercloud-ansible-QIuC3M/Standalone/service_names.yaml.txt.gz

Upgrade logs: http://logs.openstack.org/34/649434/2/check/tripleo-ci-centos-7-standalone-upgrade/8fb7ea9/logs/undercloud/home/zuul/standalone_upgrade.log.txt.gz

Job logs: http://logs.openstack.org/34/649434/2/check/tripleo-ci-centos-7-standalone-upgrade/8fb7ea9/logs/

Tags:

Revision history for this message

Jose Luis Franco (jfrancoa) wrote on 2019-04-03:

So, from my understanding, we could either add the same check in the updates workflow https://github.com/openstack/tripleo-common/blob/master/tripleo_common/actions/package_update.py#L30 or even in the python-tripleoclient code so we would catch it even sooner: https://github.com/openstack/python-tripleoclient/blob/master/tripleoclient/v1/overcloud_upgrade.py#L34

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-04-04: Fix proposed to python-tripleoclient (master)

Fix proposed to branch: master
Review: https://review.openstack.org/650061

Changed in tripleo:
status:	New → In Progress

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-04-09: Fix merged to python-tripleoclient (master)

Reviewed: https://review.openstack.org/650061
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=0041ec4c54088f32994a2cdc7846ff0a6c46638c
Submitter: Zuul
Branch: master

commit 0041ec4c54088f32994a2cdc7846ff0a6c46638c
Author: Kamil Sambor <email address hidden>
Date: Thu Apr 4 18:08:07 2019 +0200

Add checking mechanism driver during upgrade

    Add checking of mechanism driver during prep upgrade.
    Prevent upgrading a stack to a version of tripleo templates or
    environment that specifies neutron mechanism drivers that are
    incompatible with the existing stack.

Change-Id: Ia6085ca63de0d8c48ab9c5b5811f6ac3e5141c85
Closes-Bug: #1823042

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-04-11: Fix proposed to python-tripleoclient (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.openstack.org/651809

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-04-12: Fix merged to python-tripleoclient (stable/stein)

Reviewed: https://review.openstack.org/651809
Committed: https://git.openstack.org/cgit/openstack/python-tripleoclient/commit/?id=f09d8402236f449a9d41eb0a5fe1faf7623982b5
Submitter: Zuul
Branch: stable/stein

commit f09d8402236f449a9d41eb0a5fe1faf7623982b5
Author: Kamil Sambor <email address hidden>
Date: Thu Apr 4 18:08:07 2019 +0200

Add checking mechanism driver during upgrade

    Change-Id: Ia6085ca63de0d8c48ab9c5b5811f6ac3e5141c85
    Closes-Bug: #1823042
    (cherry picked from commit 0041ec4c54088f32994a2cdc7846ff0a6c46638c)