tripleo

Deployment with custom network names fails due to mismatch in subnet names

Bug #1832759 reported by Harald Jensås on 2019-06-13

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	tripleo	Fix Released	Medium	Harald Jensås	tripleo train-2

Bug Description

Deployment with custom network names fails due to mismatch in subnet names.

Custom network data with renamed name_lower for network.

- name: InternalApi
  name_lower: MyInternalApiNet
  service_net_map_replace: internal_api
  vip: true
  vlan: 20
  ip_subnet: '172.16.2.0/24'

openstack overcloud deploy \
< .. snip .. >
-n /home/stack/virt/network/network_data.yaml
< .. snip .. >

No custom roles data file.

The deployment fails with:

overcloud.Compute.0.InternalApiPort:
  resource_type: OS::TripleO::Compute::Ports::InternalApiPort
  physical_resource_id:
  status: CREATE_FAILED
  status_reason: |
    resources.InternalApiPort: Property error: resources.InternalApiPort.properties.fixed_ips[0].subnet: Error validating value 'internal_api_subnet': Unable to find subnet with name or id 'internal_api_subnet'

This happens because the subnet specified in roles_data.yaml[1] is'nt updated to match the renamed name_lower for the InternalApi network.

https://github.com/openstack/tripleo-heat-templates/blob/master/roles/Compute.yaml#L13

Tags:

OpenStack Infra (hudson-openstack) on 2019-06-13

Changed in tripleo:
status:	Triaged → In Progress

Revision history for this message

Harald Jensås (harald-jensas) wrote on 2019-06-13:

Fix proposed: https://review.opendev.org/664988

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-06-15: Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/664988
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=564d89b2f8609c79a2c21224c72a15b45397fbb7
Submitter: Zuul
Branch: master

commit 564d89b2f8609c79a2c21224c72a15b45397fbb7
Author: Harald Jensås <email address hidden>
Date: Wed Jun 12 19:49:20 2019 +0200

Fix network rename + service_net_map_replace

    If name_lower of a network is changed, and service_net_map_replace
    is used. The subnet defined for the network in roles_data would
    have to be updated to match the new name_lower. This was not the
    case prior to stein, because roles_data did'nt include the subnet.

    A downstream regression test is failing because of this. The
    workaround is to update roles_data with a value for the subnet
    that match name_lower.

    This patch should fix the need to update roles_data in the case
    that the net_map_replace matches the subnet in roles_data and no
    additional subnet with this defined for this network in
    network_data.

Closes-Bug: #1832759
Change-Id: I10f99fad0f0016bf81edd53e1c5579f9d5c0ef88

Changed in tripleo:
status:	In Progress → Fix Released

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-06-15: Fix proposed to tripleo-heat-templates (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/665503

Revision history for this message

OpenStack Infra (hudson-openstack) wrote on 2019-06-19: Fix merged to tripleo-heat-templates (stable/stein)

Reviewed: https://review.opendev.org/665503
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=459b873c299c2dbf028f6d59f44ad33237c222c9
Submitter: Zuul
Branch: stable/stein

commit 459b873c299c2dbf028f6d59f44ad33237c222c9
Author: Harald Jensås <email address hidden>
Date: Wed Jun 12 19:49:20 2019 +0200

Fix network rename + service_net_map_replace

    A downstream regression test is failing because of this. The
    workaround is to update roles_data with a value for the subnet
    that match name_lower.

    Closes-Bug: #1832759
    Change-Id: I10f99fad0f0016bf81edd53e1c5579f9d5c0ef88
    (cherry picked from commit 564d89b2f8609c79a2c21224c72a15b45397fbb7)