Issues affecting custom formatting tags
Bug #1832993 reported by
Phill
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| OpenLP |
Fix Committed
|
Medium
|
Phill | ||
Bug Description
Add a custom formatting tag to a song causes some issues:
1. The closing tags shows on the main display
2. Other formatting tags do not render correctly when custom tags are used
When inserting a custom tag by right clicking in the song editor the closing tag is inserted but with out the '/'
Related branches
lp://qastaging/~phill-ridout/openlp/wow_import_fixes
- Tim Bentley: Approve
-
Diff: 746 lines (+467/-100)12 files modifiedopenlp/core/common/i18n.py (+2/-1)
openlp/core/lib/__init__.py (+54/-1)
openlp/core/ui/formattingtagcontroller.py (+1/-1)
openlp/core/widgets/edits.py (+1/-1)
openlp/plugins/songs/lib/importers/wordsofworship.py (+146/-79)
tests/functional/openlp_core/lib/test_lib.py (+180/-2)
tests/functional/openlp_plugins/songs/test_wordsofworshipimport.py (+36/-12)
tests/resources/songs/wordsofworship/Amazing Grace (6 Verses)_v2_1_2.json (+1/-1)
tests/resources/songs/wordsofworship/Holy Holy Holy Lord God Almighty_v2_1_2.json (+1/-1)
tests/resources/songs/wordsofworship/Test_Song_v2_0_0.json (+18/-0)
tests/resources/songs/wordsofworship/Test_Song_v2_1_2.json (+26/-0)
tests/resources/songs/wordsofworship/When morning gilds the skies_v2_0_0.json (+1/-1)
| Changed in openlp: | |
| status: | New → Fix Committed |
| milestone: | none → 2.9.1 |
| assignee: | nobody → Phill (phill-ridout) |
Revision history for this message
| Johnthan (johnmfl) wrote | #1 |
To post a comment you must log in.
Windows 10 32 bit
This has been verified to not happen in trunk 2892