tripleo

all-nodes validation script has issues with boolean checks

Bug #1833441 reported by Alex Schultz
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tripleo
Fix Released
Low
Alex Schultz
tripleo train-2

Bug Description

In the validations-scripts/all-nodes.sh, if the conditional variables are "true" rather than "True", the validations end up not being run correctly. The conditionals should be case-insensitive if possible to prevent false negatives.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (master)

Fix proposed to branch: master
Review: https://review.opendev.org/666324

Changed in tripleo:
status: Triaged → In Progress
Alex Schultz (alex-schultz)
Changed in tripleo:
milestone: none → train-2
tags: added: queens-backport-potential rocky-backport-potential stein-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (master)

Reviewed: https://review.opendev.org/666324
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=7ac8cf9c281f97b320192ca088c72a1bdf8de9f3
Submitter: Zuul
Branch: master

commit 7ac8cf9c281f97b320192ca088c72a1bdf8de9f3
Author: Alex Schultz <email address hidden>
Date: Wed Jun 19 09:52:06 2019 -0600

    Make comparisons case insensitive

    If the values for the conditional checks are "true" rather than "True",
    they would be skipped. Let's force the variable contents to lowercase to
    remove the possibility of skipping the check when the value is "true"

    Change-Id: I9f288ee2771c0a954beee085b6df650419978422
    Closes-Bug: #1833441

Changed in tripleo:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/stein)

Fix proposed to branch: stable/stein
Review: https://review.opendev.org/667622

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/rocky)

Fix proposed to branch: stable/rocky
Review: https://review.opendev.org/667625

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to tripleo-heat-templates (stable/queens)

Fix proposed to branch: stable/queens
Review: https://review.opendev.org/667626

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/stein)

Reviewed: https://review.opendev.org/667622
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=f736d4471eee45492fe8d1fc06c54dd91d384a62
Submitter: Zuul
Branch: stable/stein

commit f736d4471eee45492fe8d1fc06c54dd91d384a62
Author: Alex Schultz <email address hidden>
Date: Wed Jun 19 09:52:06 2019 -0600

    Make comparisons case insensitive

    If the values for the conditional checks are "true" rather than "True",
    they would be skipped. Let's force the variable contents to lowercase to
    remove the possibility of skipping the check when the value is "true"

    Change-Id: I9f288ee2771c0a954beee085b6df650419978422
    Closes-Bug: #1833441
    (cherry picked from commit 7ac8cf9c281f97b320192ca088c72a1bdf8de9f3)

tags: added: in-stable-stein
tags: added: in-stable-rocky
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/rocky)

Reviewed: https://review.opendev.org/667625
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=5d35daee0d3e7e6b8f00a07c5f164622a75cb101
Submitter: Zuul
Branch: stable/rocky

commit 5d35daee0d3e7e6b8f00a07c5f164622a75cb101
Author: Alex Schultz <email address hidden>
Date: Wed Jun 19 09:52:06 2019 -0600

    Make comparisons case insensitive

    If the values for the conditional checks are "true" rather than "True",
    they would be skipped. Let's force the variable contents to lowercase to
    remove the possibility of skipping the check when the value is "true"

    Change-Id: I9f288ee2771c0a954beee085b6df650419978422
    Closes-Bug: #1833441
    (cherry picked from commit 7ac8cf9c281f97b320192ca088c72a1bdf8de9f3)

tags: added: in-stable-queens
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to tripleo-heat-templates (stable/queens)

Reviewed: https://review.opendev.org/667626
Committed: https://git.openstack.org/cgit/openstack/tripleo-heat-templates/commit/?id=daa050438a0a379bac52e8e66055dd9bed59cd21
Submitter: Zuul
Branch: stable/queens

commit daa050438a0a379bac52e8e66055dd9bed59cd21
Author: Alex Schultz <email address hidden>
Date: Wed Jun 19 09:52:06 2019 -0600

    Make comparisons case insensitive

    If the values for the conditional checks are "true" rather than "True",
    they would be skipped. Let's force the variable contents to lowercase to
    remove the possibility of skipping the check when the value is "true"

    Change-Id: I9f288ee2771c0a954beee085b6df650419978422
    Closes-Bug: #1833441
    (cherry picked from commit 7ac8cf9c281f97b320192ca088c72a1bdf8de9f3)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 10.6.0

This issue was fixed in the openstack/tripleo-heat-templates 10.6.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 11.1.0

This issue was fixed in the openstack/tripleo-heat-templates 11.1.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 9.4.1

This issue was fixed in the openstack/tripleo-heat-templates 9.4.1 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/tripleo-heat-templates 8.4.1

This issue was fixed in the openstack/tripleo-heat-templates 8.4.1 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.