Vandelay import page load hangs (greedy combobox)

Bug #1844812 reported by Bill Erickson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned

Bug Description

Seen on Evergreen 3.4.

Navigating to the MARC Batch Import/Export UI fails to complete loading and causes the browser to freeze up with high CPU usage (i.e. an infinite loop).

I believe this is a result of this patch, which made the combobox more responsive to post-initialization data changes.

https://git.evergreen-ils.org/?p=Evergreen.git;a=commitdiff;h=028e70f6916a872a0b7b8c0fd73cbae70ed03648

The solution is to teach the entry list Input() to only proceed with processing the values if they represent a change, since it's not uncommon for functionally equivalent values to be passed to the Input() as the page is initially rendered.

Patch en route.

Revision history for this message
Bill Erickson (berick) wrote :
tags: added: pullrequest
Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Galen Charlton (gmc) wrote :

Works for me. Pushed to master for inclusion in the 3.4-rc. Thanks, Bill!

Changed in evergreen:
status: New → Confirmed
assignee: nobody → Galen Charlton (gmc)
milestone: 3.4-beta2 → 3.4-rc
status: Confirmed → Fix Committed
assignee: Galen Charlton (gmc) → nobody
Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.