kolla-ansible

enabling cinder for lvm enables cinder backup as well which does not support lvm

Bug #1849827 reported by Radosław Piliszek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kolla-ansible
Triaged
Medium
Unassigned
Victoria
Triaged
Medium
Unassigned
kolla-ansible 11.1.0 "victoria"

Bug Description

Cinder Backup does not support LVM, see:
https://docs.openstack.org/cinder/rocky/drivers.html#backup-drivers

Cinder Backup is forced as 'yes' and enabling Cinder enables relevant roles which deploy Cinder Backup as well.

Cinder Backup is (also unconditionally) configured to use Ceph which is unlikely to be deployed there.

The impact is that there are cinder backup processes running which only report errors to logs. The relevant functionality is advertised in APIs
and Horizon but it is obviously broken.

See original description
Tags: backup cinder lvm
Revision history for this message
Radosław Piliszek (yoctozepto) wrote :

CI patch: https://review.opendev.org/691289

description: updated
Michal Nasiadka (mnasiadka)
Changed in kolla-ansible:
assignee: nobody → Michal Nasiadka (mnasiadka)
milestone: none → 10.0.0
Revision history for this message
Mark Goddard (mgoddard) wrote :

Let's turn this on its head - 'cinder-backup enabled when cinder ceph backend is disabled'. It should be possible to have multiple backends (I think).

Revision history for this message
Michal Nasiadka (mnasiadka) wrote :

Yes - but this is the default: https://github.com/openstack/kolla-ansible/blob/master/ansible/group_vars/all.yml#L868

It does not depend on if ceph is enabled or not.

And even if it would - which of the backends we should enable by default:
https://github.com/openstack/kolla-ansible/blob/ade4f4eeb413a06f57e50bdb5462f8407023feb3/ansible/roles/cinder/templates/cinder.conf.j2#L28-L50

nfs or swift? ;-)

I would say we need a feature named posix filesystem and default to that, or fail if the backend is not defined and default to an empty choice?

Revision history for this message
Radosław Piliszek (yoctozepto) wrote :

Default to backup disabled. It's optional. ;-)

Revision history for this message
Mark Goddard (mgoddard) wrote :

Another thing to bear in mind - anyone using a custom driver might be annoyed if we disable backup by default.

Revision history for this message
Radosław Piliszek (yoctozepto) wrote :

So what do we do? :-)

Revision history for this message
Mark Goddard (mgoddard) wrote :

I don't think it's a big deal. There can be multiple backends, they might even be in custom config we can't see. If your config doesn't have a working backup driver, disable cinder backup.

Revision history for this message
Michal Nasiadka (mnasiadka) wrote :

So - as a summary - this is 'works as designed' approach to this bug? ;-)
Maybe we should default to an empty configuration? as per https://docs.openstack.org/cinder/train/configuration/block-storage/backup-drivers.html and add a mention in the docs, that cinder-backup is deployed by default when cinder is enabled, but if you don't configure a backend - it will be unconfigured?
It wouldn't break existing installations I guess. Question if cinder-backup will start with empty backup_* config...

Changed in kolla-ansible:
assignee: Michal Nasiadka (mnasiadka) → nobody
Revision history for this message
Radosław Piliszek (yoctozepto) wrote :

@mnasiadka: good catch, worth trying out there.

Mark Goddard (mgoddard)
Changed in kolla-ansible:
milestone: 11.0.0 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.