kibana role broken with ansible 2.9

Bug #1851258 reported by Martin Lukas
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
kolla-ansible
Fix Released
High
Radosław Piliszek
Stein
Fix Committed
High
Radosław Piliszek
Train
Fix Released
High
Radosław Piliszek

Bug Description

With ansible 2.9 the deployment fails when kibana is enabled.

What happened:
- Install ansible using `pip install ansible` now installs ansible 2.9
- Install kolla and kolla-ansible from git with stable/stein branch
- Execute `kolla-ansible -i ./multinode bootstrap-servers`
- Execute `kolla-ansible -i ./multinode prechecks`
- Execute `kolla-ansible -i ./multinode deploy`

Deployment fails in kibana role:
`fatal: [mlcopnstk01]: FAILED! => {"changed": false, "msg": "Unsupported parameters for (uri) module: HEADER_Content-Type Supported parameters include: attributes, backup, body, body_format, client_cert, client_key, content, creates, delimiter, dest, directory_mode, follow, follow_redirects, force, force_basic_auth, group, headers, http_agent, method, mode, owner, regexp, remote_src, removes, return_content, selevel, serole, setype, seuser, src, status_code, timeout, unix_socket, unsafe_writes, url, url_password, url_username, use_proxy, validate_certs"}`

This task causes the trouble:
`- name: Get kibana default indexes
  uri:
    HEADER_Content-Type: application/json
    url: "{{ internal_protocol }}://{{ kolla_internal_vip_address }}:{{ elasticsearch_port }}/.kibana"
    method: GET
  register: kibana_default_indexes
  run_once: true
  when: kibana_default_index is defined`

According to the ansible documentation, the HEADER_* parameters are no longer supported in ansible 2.9, see here: https://docs.ansible.com/ansible/2.8/modules/uri_module.html

What you expected to happen:
- Kibana should deploy without problems

**Environment**:
* OS: CentOS Linux release 7.7.1908
* Kernel (e.g. `uname -a`): 3.10.0-957.el7.x86_64
* Docker version if applicable (e.g. `docker version`): 19.03.4
* Kolla-Ansible version (e.g. `git head or tag or stable branch` or pip package version if using release): stable/stein
* Docker image Install type (source/binary): source
* Docker image distribution:
* Are you using official images from Docker Hub or self built? official images
* If self built - Kolla version and environment used to build:
* Share your inventory file, globals.yml and other configuration files if relevant

Revision history for this message
Martin Lukas (lxfozzibaer) wrote :

Oh, forgot to mention: When installing ansible 2.8 directly using pip the deployment continues.

Changed in kolla-ansible:
status: New → Triaged
importance: Undecided → High
milestone: none → 9.0.0
assignee: nobody → Radosław Piliszek (yoctozepto)
Revision history for this message
Radosław Piliszek (yoctozepto) wrote :
no longer affects: kolla-ansible/rocky
Revision history for this message
Radosław Piliszek (yoctozepto) wrote :
Revision history for this message
Mark Goddard (mgoddard) wrote :

We need to set an upper limit for Ansible. Otherwise we'll keep getting hit by these issues because it's not backwards compatible.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to kolla-ansible (stable/stein)

Reviewed: https://review.opendev.org/692859
Committed: https://git.openstack.org/cgit/openstack/kolla-ansible/commit/?id=79c2546d831504fa570389a611001c8af06fadd8
Submitter: Zuul
Branch: stable/stein

commit 79c2546d831504fa570389a611001c8af06fadd8
Author: Raimund Hook <email address hidden>
Date: Sat May 4 18:48:03 2019 +0100

    Updated ansible uri module HEADERS_ field

    This fixes a deprecation warning that gets displayed when running
    the kibana/post_config 'Get kibana default indexes' task.

    HEADERS_ has been deprecated since ansible 2.1 and will be
    removed in 2.9.

    https://docs.ansible.com/ansible/latest/modules/uri_module.html

    This fixes Ansible 2.9 support.

    Change-Id: I177113c606119505c6cb69c66a326f7cbdaf2196
    Closes-bug: #1851258
    (cherry picked from commit 726ba753417fc3d1338b90b8c6d59479e8987f45)

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/kolla-ansible 8.1.0

This issue was fixed in the openstack/kolla-ansible 8.1.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.