Evergreen

Tidy Default Classification Scheme Description

Bug #1856097 reported by Kyle Huckins
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Low
Unassigned
Evergreen 3.10-rc

Bug Description

Noted in testing of the Angular port of the Org Unit Settings Editor(bug 1839341), it was noted that the Default Classification Scheme description could stand to be updated, now that the UI gives a list of available options, rather than requiring a manual input of the correct ID. There may be other settings with this situation, as well.

Kyle Huckins (khuckins)
Changed in evergreen:
assignee: nobody → Kyle Huckins (khuckins)
Revision history for this message
Kyle Huckins (khuckins) wrote :

I've pushed a branch here: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/khuckins/lp1856097-tidy-default-classification-scheme-description

tags: added: pullrequest
Changed in evergreen:
assignee: Kyle Huckins (khuckins) → nobody
Revision history for this message
Terran McCanna (tmccanna) wrote :

I can verify that this patch updates the wording on the "Default Classification Scheme" library setting properly. However, the dropdown list is still showing 1, 2, and 3 because the work for bug 1839341 and bug 1850555 have not yet been signed off and committed. After those are completed, this can be tested again and signed off pretty quickly.

Terran McCanna (tmccanna)
tags: added: needsrepatch
Changed in evergreen:
milestone: none → 3.next
Revision history for this message
Terran McCanna (tmccanna) wrote :

Noting that bug 1850555 has been committed, but bug 1839341 still needs work.

tags: removed: needsrepatch
Revision history for this message
Jennifer Pringle (jpringle-u) wrote :

I don't think this fix is working properly with the angular library settings editor.

For the library setting description I'm seeing "Defines the default classification scheme for new call numbers: 1 = Generic; 2 = Dewey; 3 = LC" and I think it's supposed to be just "Defines the default classification scheme for new call numbers"

Revision history for this message
Terran McCanna (tmccanna) wrote :

Confirmed Jennifer's comment #4 that the description still needs to be updated.

(And noting that this cannot be committed until after bug 1839341 is committed.)

tags: added: needswork
removed: pullrequest
Revision history for this message
Terran McCanna (tmccanna) wrote :

Re-adding pullrequest as bug 1839341 has been signed off.

tags: added: pullrequest
removed: needswork
Revision history for this message
Susan Morrison (smorrison425) wrote :

I have tested this code and consent to signing off on it with my name, Susan Morrison, and my email address, <email address hidden>.

tags: added: signedoff
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Thanks, Kyle and Susan! Merged for inclusion in the 3.10 release candidate. I also made two small corrections to the upgrade script:

1) Don't apply the upgrade if it would overwrite existing customizations to the description
2) add a missing semicolon.

Changed in evergreen:
status: New → Fix Committed
importance: Undecided → Low
milestone: 3.next → 3.10-rc
Jane Sandberg (sandbergja)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.