Angular Org Unit Selector Incorrect Order

Bug #1857350 reported by Terran McCanna
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Undecided
Unassigned
3.3
Fix Released
Undecided
Unassigned

Bug Description

In 3.4:

The org unit selectors in the new Angular interfaces are not ordered correctly. The indentations are correct, but the systems are not alphabetical, and the branches within the systems are not alphabetical. Some screenshots attached.

This is the case for all locations where the component is used - carousel editor, hopeless holds, shelving location editor, non-cataloged types editor, statistical categories editor, etc.

Revision history for this message
Terran McCanna (tmccanna) wrote :
Changed in evergreen:
status: New → Confirmed
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Fix pushed:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1857350-org-select-sort

Includes repairs and unit test for an existing (but never used) org tree sorting function in the org service.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.4.2
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Galen Charlton (gmc) wrote :

Signoff along with a follow-up to quiet ng-lint pushed to user/gmcharlt/lp1857350_ang_ou_sorting_signoff.

tags: added: signedoff
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Thanks, Galen. Merged to 3.3 and up.

Note the lint fix was not required for 3.3.

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Terran McCanna (tmccanna) wrote :

Thanks Bill and Galen!

Revision history for this message
Dan Scott (denials) wrote :

And there was much rejoicing - thank you!

Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.