redfish power driver tweaks
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Medium
|
Freddy | ||
Bug Description
After adding several Hewlett Packard Enterprise nodes to a 2.6 MaaS installation the following changes were required to the redfish power driver:
- In get_node_id, trim trailing slashes prior to running os.path.basename. HPE nodes returned Members items with a a trailing slash, e.g. '/redfish/
- remove Action key from Power body. this key isn't in the redfish schema and is rejected with a 400 from HPE ILOs http://
- in power_off, set_pxe_boot after issuing power_off command. this prevents setting pxe boot while server is in POST, which results in a 409 from HPE ILOs.
I've put these fixes together in a merge request, linked below. There are unit tests in the merge and I can confirm these changes have worked across a fleet of Cisco, Dell, and HPE out of band devices. Can someone please review this?
https:/
Related branches
- Newell Jensen (community): Approve
- Alberto Donato (community): Approve
- MAAS Lander: Approve
-
Diff: 97 lines (+49/-8)2 files modifiedsrc/provisioningserver/drivers/power/redfish.py (+5/-8)
src/provisioningserver/drivers/power/tests/test_redfish.py (+44/-0)
| Freddy (fwieffering) wrote | #1 |
| Changed in maas: | |
| status: | New → In Progress |
| importance: | Undecided → Medium |
| assignee: | nobody → Freddy (fwieffering) |
| Changed in maas: | |
| milestone: | none → next |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| milestone: | next → 2.8.0b1 |
| status: | Fix Committed → Fix Released |
The merge request now passes the maas-lander checks.