Ubuntu
gnome-shell package

Text clipped on password overlay dialogues

Bug #1866259 reported by Matthew Ruffell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
GNOME Shell
New
Unknown
gnome-shell (Ubuntu)
Fix Released
Low
Unassigned
Focal
Fix Released
Low
Unassigned
yaru-theme (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Fix Released
Undecided
Unassigned

Bug Description

On focal with yaru-gtk-theme 20.04.2, the text in the password overlay dialogue boxes is clipped. Possibly the font is too big, or the dialogue box not wide enough?

Attached is a screenshot of attempting to mount an encrypted disk image in
gnome-disks, and I can also reproduce this issue trying to unlock a SSH key.

See original description
Revision history for this message
Matthew Ruffell (mruffell) wrote :
description: updated
Revision history for this message
MadsRH (madsrh) wrote :

Hi Matthew

Could you check if the text is also clipped using the Adwaita theme? If so, then it's a bug in Gnome Disks, as you already mentioned, where the dialogue box isn't wide enough.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Gnome Shell owns this code (it's the internal St toolkit).

affects: yaru-theme (Ubuntu) → gnome-shell (Ubuntu)
Changed in gnome-shell (Ubuntu):
importance: Undecided → Low
Revision history for this message
Matthew Ruffell (mruffell) wrote :

Hello MadsRH and Daniel,
I checked the Adwaita theme, and no text clipping is seen, and things are as expected. Attached is a screenshot of the same gnome-disks password dialogue in Adwaita.

Revision history for this message
Matthew Ruffell (mruffell) wrote :

I went and checked Yaru theme from Eoan, and the dialogue is displayed correctly. Maybe something broke on the move to the new dialogue box? Attached is the same gnome-disks dialogue on Eoan.
I still think the issue is the font is too big on the title of the new Yaru theme dialogue box.

Revision history for this message
Matthew Ruffell (mruffell) wrote :

I found the bug. The font-size is too large in .message-dialog-content .message-dialog-title.
It is set to 18pt, but the largest it should be is 13pt.
Attached is a picture demonstrating each font size, no other changes made.

Revision history for this message
Matthew Ruffell (mruffell) wrote :

I did some extensive digging and found why it is fixed in Adwaita and not Yaru.

Two weeks ago, the below commit was merged to gnome-shell. It checks to see if the string width is longer than the box width, and if it is, it switches to a hardcoded "leightweight" width of 13pt.

commit 80a869e7686adf772512069d7818bda0379190d8
Author: Jonas Dreßler <email address hidden>
Date: Mon Feb 17 19:59:31 2020 +0100
Subject: dialogs: Use a smaller font-size if the title width exceeds the space

Link: https://gitlab.gnome.org/GNOME/gnome-shell/-/commit/80a869e7686adf772512069d7818bda0379190d8

This commit is present in the gnome-shell 3.35.91-1ubuntu2 package in focal.

Looking at the upstream Yaru sources, this "leightweight" tag is already merged, so I think this makes things Fix Committed.

https://github.com/ubuntu/yaru/blob/master/gnome-shell/src/gnome-shell-sass/widgets/_dialogs.scss#L32-L47

I built Yaru from source and tested it, and it works. For some reason the title is not Bold, no idea why, but the user experience is much better. Attached is a picture from upstream Yaru.

So Fix Committed. Will have to wait for Yaru master to land in Focal.

Matthew Ruffell (mruffell)
Changed in gnome-shell (Ubuntu):
status: New → Fix Released
Changed in yaru-theme (Ubuntu Focal):
status: New → Fix Committed
Revision history for this message
Sebastien Bacher (seb128) wrote :

Focal got a yaru update now

Changed in yaru-theme (Ubuntu Focal):
status: Fix Committed → Fix Released
Bug Watch Updater (bug-watch-updater)
Changed in gnome-shell:
status: Unknown → New
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.