Ceph Monitor Charm

gate test bundles do not exercise proposed changes

Bug #1873090 reported by Ryan Beisner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ceph Monitor Charm
Fix Released
Medium
Unassigned
Ceph Monitor Charm 22.04

Bug Description

"charm: ceph-mon"

When manually deploying the gate test bundle for ceph-mon:

 * https://opendev.org/openstack/charm-ceph-mon/src/branch/master/tests/bundles/bionic-queens.yaml#L10-L11

It ended up deploying:

ubuntu@juju-9b16b3-ceph-foo-0:/var/lib/juju/agents/unit-ceph-mon-0/charm$ cat repo-info
commit-sha-1: 1e05acf2df16b147f2f5910f1a9924ca093537ed
commit-short: 1e05acf
branch: HEAD
remote: https://github.com/openstack/charm-ceph-mon
info-generated: Mon Feb 17 17:12:28 UTC 2020
note: This file should exist only in a built or released charm artifact (not in the charm source code tree).

which is actually deploying the STABLE ceph-mon charm from openstack-charmers/ceph-mon, evidenced by:

 * https://api.jujucharms.com/charmstore/v5/~openstack-charmers/ceph-mon-45/archive/repo-info

containing:

commit-sha-1: 1e05acf2df16b147f2f5910f1a9924ca093537ed
commit-short: 1e05acf
branch: HEAD
remote: https://github.com/openstack/charm-ceph-mon
info-generated: Mon Feb 17 17:12:28 UTC 2020
note: This file should exist only in a built or released charm artifact (not in the charm source code tree).

which means that users cannot just `juju deploy` the test bundle, and we must look at all zaza bundles and make sure they use the relative ./ local path.

See original description
Ryan Beisner (1chb1n)
Changed in charm-ceph-mon:
importance: Undecided → Critical
milestone: none → 20.05
Revision history for this message
Ryan Beisner (1chb1n) wrote :
Download full text (6.5 KiB)

This appears to be the extent of the impact:

./vault/src/tests/bundles/xenial-ha-mysql.yaml: charm: vault
./vault/src/tests/bundles/xenial-mysql.yaml: charm: vault
./vault/src/tests/bundles/focal-mysql8.yaml: charm: vault
./swift-proxy/tests/bundles/xenial-pike.yaml: charm: swift-proxy
./swift-proxy/tests/bundles/bionic-rocky.yaml: charm: swift-proxy
./swift-proxy/tests/bundles/bionic-queens.yaml: charm: swift-proxy
./swift-proxy/tests/bundles/xenial-queens.yaml: charm: swift-proxy
./swift-proxy/tests/bundles/bionic-stein.yaml: charm: swift-proxy
./swift-proxy/tests/bundles/xenial-mitaka.yaml: charm: swift-proxy
./swift-proxy/tests/bundles/focal-ussuri.yaml: charm: swift-proxy
./swift-proxy/tests/bundles/xenial-ocata.yaml: charm: swift-proxy
./swift-proxy/tests/bundles/trusty-mitaka.yaml: charm: swift-proxy
./swift-proxy/tests/bundles/bionic-train-gr-r1.yaml: charm: swift-proxy
./swift-proxy/tests/bundles/bionic-train-gr-r2.yaml: charm: swift-proxy
./swift-proxy/tests/bundles/bionic-train.yaml: charm: swift-proxy
./swift-proxy/tests/bundles/bionic-ussuri.yaml: charm: swift-proxy
./swift-storage/tests/bundles/xenial-pike.yaml: charm: swift-storage
./swift-storage/tests/bundles/bionic-rocky.yaml: charm: swift-storage
./swift-storage/tests/bundles/bionic-queens.yaml: charm: swift-storage
./swift-storage/tests/bundles/xenial-queens.yaml: charm: swift-storage
./swift-storage/tests/bundles/bionic-stein.yaml: charm: swift-storage
./swift-storage/tests/bundles/xenial-mitaka.yaml: charm: swift-storage
./swift-storage/tests/bundles/focal-ussuri.yaml: charm: swift-storage
./swift-storage/tests/bundles/xenial-ocata.yaml: charm: swift-storage
./swift-storage/tests/bundles/trusty-mitaka.yaml: charm: swift-storage
./swift-storage/tests/bundles/bionic-train-gr-r1.yaml: charm: swift-storage
./swift-storage/tests/bundles/bionic-train-gr-r1.yaml: charm: swift-storage
./swift-storage/tests/bundles/bionic-train-gr-r1.yaml: charm: swift-storage
./swift-storage/tests/bundles/bionic-train-gr-r2.yaml: charm: swift-storage
./swift-storage/tests/bundles/bionic-train-gr-r2.yaml: charm: swift-storage
./swift-storage/tests/bundles/bionic-train-gr-r2.yaml: charm: swift-storage
./swift-storage/tests/bundles/bionic-train.yaml: charm: swift-storage
./swift-storage/tests/bundles/bionic-ussuri.yaml: charm: swift-storage
./pacemaker-remote/src/tests/bundles/bionic-basic.yaml: charm: pacemaker-remote
./ceph-mon/tests/bundles/xenial-pike.yaml: charm: ceph-mon
./ceph-mon/tests/bundles/bionic-rocky.yaml: charm: ceph-mon
./ceph-mon/tests/bundles/bionic-queens.yaml: charm: ceph-mon
./ceph-mon/tests/bundles/xenial-queens.yaml: charm: ceph-mon
./ceph-mon/tests/bundles/bionic-stein.yaml: charm: ceph-mon
./ceph-mon/tests/bundles/xenial-mitaka.yaml: charm: ceph-mon
./ceph-mon/tests/bundles/bionic-train-with-fsid.yaml: charm: ceph-mon
./ceph-mon/tests/bundles/xenial-ocata.yaml: charm: ceph-mon
./ceph-mon/tests/bundles/trusty-mitaka.yaml: charm: ceph-mon
./ceph-mon/tests/bundles/bionic-train.yaml: charm: ceph-osd
./ceph-fs/src/tests/bundles/xenial-pike.yaml: ...

Read more...

Revision history for this message
Ryan Beisner (1chb1n) wrote :
Download full text (22.7 KiB)

And the ones that (at a grep's glance) look to be correct, are:

./ceph-rbd-mirror/src/tests/bundles/bionic-queens-e2e-lxd.yaml: charm: ../../../ceph-rbd-mirror
./ceph-rbd-mirror/src/tests/bundles/bionic-queens-e2e-lxd.yaml: charm: ../../../ceph-rbd-mirror
./ceph-rbd-mirror/src/tests/bundles/xenial-pike.yaml: charm: ../../../ceph-rbd-mirror
./ceph-rbd-mirror/src/tests/bundles/xenial-pike.yaml: charm: ../../../ceph-rbd-mirror
./ceph-rbd-mirror/src/tests/bundles/bionic-rocky.yaml: charm: ../../../ceph-rbd-mirror
./ceph-rbd-mirror/src/tests/bundles/bionic-rocky.yaml: charm: ../../../ceph-rbd-mirror
./ceph-rbd-mirror/src/tests/bundles/bionic-queens-e2e.yaml: charm: ../../../ceph-rbd-mirror
./ceph-rbd-mirror/src/tests/bundles/bionic-queens-e2e.yaml: charm: ../../../ceph-rbd-mirror
./ceph-rbd-mirror/src/tests/bundles/bionic-queens.yaml: charm: ../../../ceph-rbd-mirror
./ceph-rbd-mirror/src/tests/bundles/bionic-queens.yaml: charm: ../../../ceph-rbd-mirror
./ceph-rbd-mirror/src/tests/bundles/xenial-queens.yaml: charm: ../../../ceph-rbd-mirror
./ceph-rbd-mirror/src/tests/bundles/xenial-queens.yaml: charm: ../../../ceph-rbd-mirror
./ceph-rbd-mirror/src/tests/bundles/bionic-stein.yaml: charm: ../../../ceph-rbd-mirror
./ceph-rbd-mirror/src/tests/bundles/bionic-stein.yaml: charm: ../../../ceph-rbd-mirror
./ceph-rbd-mirror/src/tests/bundles/bionic-rocky-site-a.yaml: charm: ../../../ceph-rbd-mirror
./ceph-rbd-mirror/src/tests/bundles/bionic-rocky-site-b.yaml: charm: ../../../ceph-rbd-mirror
./octavia/src/tests/bundles/bionic-rocky-ha.yaml: charm: ../../../octavia
./octavia/src/tests/bundles/bionic-stein-ha.yaml: charm: ../../../octavia
./octavia/src/tests/bundles/bionic-rocky-lxd.yaml: charm: ../../../octavia
./octavia/src/tests/bundles/bionic-train-ha.yaml: charm: ../../../octavia
./octavia/src/tests/bundles/bionic-train-ha-ovn.yaml: charm: ../../../octavia
./vault/src/tests/bundles/xenial-postgres.yaml: charm: ../../../vault
./vault/src/tests/bundles/bionic-postgres.yaml: charm: ../../../vault
./vault/src/tests/bundles/disco-postgres.yaml: charm: ../../../vault
./heat/tests/bundles/xenial-pike.yaml: charm: ../../../heat
./heat/tests/bundles/bionic-rocky.yaml: charm: ../../../heat
./heat/tests/bundles/bionic-queens.yaml: charm: ../../../heat
./heat/tests/bundles/xenial-queens.yaml: charm: ../../../heat
./heat/tests/bundles/bionic-stein.yaml: charm: ../../../heat
./heat/tests/bundles/xenial-mitaka.yaml: charm: ../../../heat
./heat/tests/bundles/xenial-ocata.yaml: charm: ../../../heat
./heat/tests/bundles/trusty-mitaka.yaml: charm: ../../../heat
./heat/tests/bundles/bionic-train.yaml: charm: ../../../heat
./octavia-dashboard/src/tests/bundles/bionic-rocky.yaml: charm: ../../../octavia-dashboard
./octavia-dashboard/src/tests/bundles/eoan-train.yaml: charm: ../../../octavia-dashboard
./octavia-dashboard/src/tests/bundles/bionic-stein.yaml: charm: ../../../octavia-dashboard
./octavia-dashboard/src/tests/bundles/bionic-train.yaml: charm: ../../../octavia-dashboard
./designate/src/tests/bundles/xenial_ocata.yaml: charm: ../../../designate
./design...

Revision history for this message
Ryan Beisner (1chb1n) wrote :

While zaza may munge things to do-the-right-thing, this definitely impacts the `juju deploy ./tests/bundle/foo`, which devalues the bundles as viable examples.

If this is limited to just the `juju deploy` workflow, then this is probably Med, not Crit.

Changed in charm-ceph-mon:
importance: Critical → Medium
Revision history for this message
Ryan Beisner (1chb1n) wrote :

For the record: I would rather take out Zaza's magic munging and force the bundles to be correct and usable as-is, in-tree.

description: updated
David Ames (thedac)
Changed in charm-ceph-mon:
milestone: 20.05 → 20.08
James Page (james-page)
Changed in charm-ceph-mon:
milestone: 20.08 → none
Revision history for this message
Billy Olsen (billy-olsen) wrote (last edit ):

Bundles have all been updated during the charmhub migration changes and bundles are appropriately targeting edge risk levels for their tracks, as evidenced by [0] for example. Marking this as fix released.

[0] -https://opendev.org/openstack/charm-ceph-mon/src/branch/master/tests/bundles/focal-xena.yaml

Changed in charm-ceph-mon:
status: New → Fix Released
milestone: none → 22.04
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.