Bootstrap OPAC: follow up needed

Bug #1895398 reported by Jane Sandberg
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
Medium
Unassigned

Bug Description

The experimental bootstrap OPAC is pretty sweet! Here are some things I noticed that need to be fixed about it, though:

1) The login_modal.tt2 file contains incorrect aria syntax. A div has aria-labelledby="loginModalLabel"; loginModalLabel doesn't exist, so the aria ref is broken.

2) In the advanced search, the filters don't open for me when I click them; I just get an error message in my console.

3) In the advanced search, the "Search" button isn't visible above the fold on several screens. Since search is the primary purpose of this page, it would be helpful to have a search button above the fold (maybe just before the filters) as well as at the bottom.

4) For the record actions (place hold, permalink, etc.), only the text within the buttons is clickable. The whole button should be clickable, so as not to require super-accurate mouse aim.

5) Also in the record actions, the Print/Email button performs different functions depending on where in the button you happen to click. Since this button performs two separate functions, it should be two separate buttons.

6) Basket dropdown: You can't use keyboard nav on the entries in this dropdown, because they have a tabindex of -1.

7) Basket dropdown, when embedded in the Angular staff catalog "Patron View" tab: every other link and button is turned off in this view, but the basket dropdown still is open-able; the entries in the dropdown don't do anything, however.

8) In search results: Show More Details used to show all sorts of bibliographic details. Now, it only shows a bib call number and some holdings-level details. It would be good to have some of those details back.

9) Tooltips (such as the guidance for login credentials or hold activation date) can't be opened using keyboard navigation.

10) In the basket view: the basket action buttons aren't working correctly here.

Revision history for this message
Jane Sandberg (sandbergja) wrote :

Oh, and one more: the language picker shouldn't need a separate "Save" button. Most language pickers I've seen just apply the new language when the user selects it.

Revision history for this message
Jane Sandberg (sandbergja) wrote :

To add more information to #10: the "Add to new list", "Print", and "Email" buttons on the view basket page all just empty the basket, rather than doing the task the user requested.

Revision history for this message
Christopher Burton (cburton) wrote :

I will look into fixing these things. Since the move to Master, the location of dependecies and other stuff have been modified. The OPAC will have to be modified too.

For example, #2 the console error for the Search Filters is occuring due to a difference in expected variables in a newer incremental Bootstrap version.

Most of this should be easy to fix and I already have some fixes in mind.

Thank you so much for testing.

Changed in evergreen:
assignee: nobody → Christopher Burton (cburton)
Revision history for this message
Christopher Burton (cburton) wrote :

I just pushed a couple commits that takes care of most of this:

1) Login modal Aria-labelledby removed. The modal doesn’t have a label.
2) Due to a slight change in versioning, an issue occurred where another attribute had to be added.
3) Added Buttons back to the middle.
4) Fixed button clicking issues on results and summary.
5) Print and email separated (Still needs https://bugs.launchpad.net/evergreen/+bug/1895676 resolved)
6) Tabindex removed and now the cart navigation can be controlled by keyboard
7) Data Toggle added to disabled elements on staff OPAC
8) Not sure what details are missing in the "More Details" section. I did some old/new comparisons with the OPAC and some of the default books found in the search and their information was matching up)
9)Tooltips changed to allow keyboard navigation and popups
10) Name was missing from the buttons, so it wasn’t passing actions properly.
11) Move Language to footer as links. This will make it widely accessible and noticable. Having a dropdown was not appealing and removing the submit button would cause it to not be acceptable. I think they call it a "jump box" because as soon as you make the selection it redirects you, giving no chance to change it. It's not expected behaviour from a dropdown.

2 commits were made:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=97221be6bc08e82bb76763753823dec6469f8615

And a follow up

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=9f6befd9c877340ce14130936975d4824d353c5f

Revision history for this message
Eva Cerninakova (ece) wrote :

I agree with Jane that the interface looks really nice. Great work ;-)

I came across some more issues:

1) In the OPAC pre-registration form, I am not able to pick the home library.

2) The My Account link does not have visible focus, which is very confusing when using the TAB key for navigating the page.

3) In Advanced search, the option for the searching the phrase "ending in" is missing in the dropdown-box, although the function "end in" is present and works fine.

tags: added: pullrequest
Revision history for this message
Terran McCanna (tmccanna) wrote :

Adding another:

When using the Bootstrap OPAC from within the staff client, filling a basket and then click Add to Bucket gives a URL not found error.

Revision history for this message
Terran McCanna (tmccanna) wrote :

I split comment 6 into a different bug: https://bugs.launchpad.net/evergreen/+bug/1898775

Revision history for this message
Galen Charlton (gmc) wrote :

I've merged this to master and rel_3_6, along with a follow-up to show focus on the My Account / login link per Eva's observation. Thanks, Chris!

I don't see where the advanced search page ever had a "ending in" operator, and I was able to select a home library on the patron self-registration page.

I'm closing out this bug for the release; please open new bugs for any new or continuing issues.

Changed in evergreen:
milestone: none → 3.6-rc
importance: Undecided → Medium
status: New → Confirmed
assignee: Christopher Burton (cburton) → nobody
status: Confirmed → Fix Committed
Revision history for this message
Christopher Burton (cburton) wrote :

Thanks Galen for making sure those fixes get in there right under the wire! And thanks Jane for all your help testing! Excited to get more feedback once it is in use!

Galen Charlton (gmc)
Changed in evergreen:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.