Evergreen

Angular: can no longer double click on item to open editor

Bug #1908568 reported by Elaine Hardy
106
This bug affects 20 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Medium
Unassigned
Evergreen 3.12-beta
3.10
Fix Committed
Undecided
Unassigned
Evergreen 3.11.2
3.11
Fix Committed
Undecided
Unassigned
Evergreen 3.10.4
3.5
Won't Fix
Undecided
Unassigned

Bug Description

In 3.4 and earlier, double clicking on an item in Holdings view opened the holdings editor. In angular, double clicking does not have the same result.

Garry Collum (gcollum)
Changed in evergreen:
status: New → Confirmed
Bill Erickson (berick)
Changed in evergreen:
assignee: nobody → Bill Erickson (berick)
Revision history for this message
Bill Erickson (berick) wrote :

Here's a fix:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/berick/lp1908568-ang-holdings-dbl-click

tags: added: pullrequest staffcatalog
Changed in evergreen:
milestone: none → 3.4.6
milestone: 3.4.6 → 3.6.2
assignee: Bill Erickson (berick) → nobody
Revision history for this message
Elaine Hardy (ehardy) wrote :

I have tested this code on a PINES concerto server and consent to signing off on it with my name, Elaine Hardy and my email address, <email address hidden>.

Terran McCanna (tmccanna)
tags: added: signedoff
Revision history for this message
Terran McCanna (tmccanna) wrote :

I'm removing the sign off because now that we have it applied to a 3.6.1 production server, we're seeing problems. Will need more testing.

tags: removed: signedoff
Revision history for this message
Elaine Hardy (ehardy) wrote :

While the editor does open with the double click, the editor is not populated with the existing item attributes, the item count is set to 2 and there is a second box for an additional item to be added. In order to save & exit, a barcode must be added.

Terran McCanna (tmccanna)
tags: added: needsrepatch
removed: pullrequest
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 3.6.2 → 3.6.3
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
milestone: 3.6.3 → none
Terran McCanna (tmccanna)
tags: added: needswork
removed: needsrepatch
Terran McCanna (tmccanna)
Changed in evergreen:
importance: Undecided → Medium
Revision history for this message
Jennifer Pringle (jpringle-u) wrote :

Confirmed still an issue in 3.9.0

Jane Sandberg (sandbergja)
Changed in evergreen:
assignee: nobody → Jane Sandberg (sandbergja)
Revision history for this message
Jane Sandberg (sandbergja) wrote :

Here is a branch, based on the original from Bill, but pointing to the new angular holdings editor: user/sandbergja/lp1908568_double_click_editor

Here is a link: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sandbergja/lp1908568_double_click_editor

To run the automated test, run `cd Open-ILS/src/eg2 && npx nightwatch nightwatch/src/staff/catalog/holdingsView.spec.ts`

Changed in evergreen:
assignee: Jane Sandberg (sandbergja) → nobody
tags: added: pullrequest
removed: needswork
Revision history for this message
Garry Collum (gcollum) wrote :

Works great. A signed-off version is at https://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=6fd91e2e69aa01512df7e837c5325212c62f1fba

tags: added: signedoff
Andrea Neiman (aneiman)
Changed in evergreen:
milestone: none → 3.12-beta
Terran McCanna (tmccanna)
Changed in evergreen:
assignee: nobody → Terran McCanna (tmccanna)
Revision history for this message
Terran McCanna (tmccanna) wrote :

Thanks Bill & Elaine & Jane & Garry!

Fix committed and pushed back as far as 3.10

Changed in evergreen:
status: Confirmed → Fix Committed
assignee: Terran McCanna (tmccanna) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.