Placeholders in search form in staff catalog appears untranslated

The untranslatable placeholders for keyword search, numeric search and brosing are located in in the file Open-ILS/src/eg2/src/app/staff/catalog/search-form.component.html, see below:

The untranslatable placeholders for keyword search (Query...) is located on line no. 90:

  84 <div class="form-group">
  85 <div *ngIf="idx == 0">
  86 <input type="text" class="form-control"
  87 id='first-query-input'
  88 [(ngModel)]="context.termSearch.query[idx]"
  89 (keyup.enter)="searchByForm()"
  90 placeholder="Query..."/>
  91 </div>

The untranslatable placeholder for numeric search ("Numeric Query...") is located on line no. 283:

 278 <label for="ident-value" class="ml-2" i18n>Value</label>
 279 <input name="ident-value" id='ident-query-input'
 280 type="text" class="form-control ml-2"
 281 [(ngModel)]="context.identSearch.value"
 282 (keyup.enter)="searchByForm()"
 283 placeholder="Numeric Query..."/>

The untranslatable placeholders for browse search ("Browse for...") is located on line no. 348:

 343 <label for="query" class="ml-2"> starting with </label>
 344 <input type="text" class="form-control ml-2"
 345 id='browse-term-input' name="query"
 346 [(ngModel)]="context.browseSearch.value"
 347 (keyup.enter)="searchByForm()"
 348 placeholder="Browse for..."/>

The untranslatable placeholders for call number browsing ("Browse Call Numbers...") is located on line no. 364:

 360 <input type="text" class="form-control ml-2"
 361 id='cnbrowse-term-input' name="query"
 362 [(ngModel)]="context.cnBrowseSearch.value"
 363 (keyup.enter)="searchByForm()"
 364 placeholder="Browse Call Numbers..."/>

I can confirm that this bug is still valid for the main branch used to build Blake's test server with Czech staff client (https://bugsquash3.mobiusconsortium.org/eg2/cs-CZ/staff/catalog).

When one looks at how placeholders are marked for translation elsewhere in Evergreen, e.g. in the file https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/eg2/src/app/staff/acq/lineitem/copy-attrs.component.html;hb=3c2cc9d74dbf084b6d91700302492b05ad9b5397 (see for example line 63: placeholder="Call Number..." i18n-placeholder), it seems that perhaps adding the "i18n-placeholder" to each of the lines would work.

As things change over time, also the line numbers have changed, with the current lines being:

placeholder="Query..."/> - lines 95 and 102
placeholder="Numeric Query..."/> - line 318
placeholder="Browse for..."/> - line 394
placeholder="Browse Call Numbers..."/> - line 411

Still issue - tested on https://bugsquash3.mobiusconsortium.org/

Here's a branch to localize the placeholders: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp192012-search-form-placeholder-i18n

Stephanie, thank you very much for creating the branch!

Nice! Thanks, Stephanie, Eva, and Linda. Merged to rel_3_10 and above.