Evergreen

Some components of  the staff client search result interface appears untranslated

Bug #1920230 reported by Eva Cerninakova
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Medium
Unassigned
Evergreen 3.12-beta
3.11
Fix Committed
Undecided
Unassigned
Evergreen 3.11.2

Bug Description

Some strings in the Angular staff client search result page (Holds, Created, by, Items.) are not displayed translated (in the Evergreen 3.6.2 with Czech locale on).

I suppose the untranslated strings have not been marked for translation.  I am not very familiar with the new Angular client, so I am not able to locate the source of the strings. However, when I tried to find those untranslated string within the strings in POEditor, I was not successful. On the other hand, the string  "Edited" (ID 2165628872509841455) available in POEditor for translation is displayed as translated.

I have attached a screenshot with the untranslated strings marked.

Revision history for this message
Eva Cerninakova (ece) wrote :
Revision history for this message
Eva Cerninakova (ece) wrote :

The problem is probably caused by missig tags in following lines of Open-ILS/src/eg2/src/app/staff/catalog/result/record.component.html.

I think, that:

line 153:

             {{copyCount.available}} / {{copyCount.count}} items
should be replaced by:
            {{copyCount.available}} / {{copyCount.count}} <span i18n>items</span>

169
             Holds: {{summary.holdCount}}
should be replaced by:
             <span i18n>Holds:</span> {{summary.holdCount}}

177
             Created</span> {{summary.record.create_date() | date:'shortDate'}} by
should by replaced by:
             <span i18n>Created</span> {{summary.record.create_date() | date:'shortDate'}} <span i18n>by</span>

tags: added: bitesize
Revision history for this message
Eva Cerninakova (ece) wrote :

Still issue m in the current main branch (tested in Blakes server https://bugsquash3.mobiusconsortium.org/)

Linda Jansova (skolkova-s)
Changed in evergreen:
status: New → Confirmed
Revision history for this message
Stephanie Leary (stephanieleary) wrote :

Thanks for the detailed bug report, Eva!

Here's a branch that localizes these strings: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/sleary/lp1920230-staffcat-record-i18n

tags: added: pullrequest
Revision history for this message
Linda Jansova (skolkova-s) wrote :

Thank you, Stephanie!

Terran McCanna (tmccanna)
Changed in evergreen:
milestone: none → 3.12-beta
assignee: nobody → Terran McCanna (tmccanna)
importance: Undecided → Medium
Revision history for this message
Terran McCanna (tmccanna) wrote :

Thanks, Stephanie - confirmed fix and pushed to main, 3.12, and 3.11. Did not apply cleanly to 3.10.

Changed in evergreen:
status: Confirmed → Fix Committed
tags: added: signedoff
Changed in evergreen:
assignee: Terran McCanna (tmccanna) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.