Option to override Buyer SAN for select ACQ providers

Bug #1930753 reported by Bill Erickson
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Evergreen
Fix Committed
Wishlist
Unassigned

Bug Description

Evergreen 3.7

The Buyer SAN value applied to EDI messages typically comes from the 'san' field on the mailing address of the ordering agency org unit. We have one vendor that requires we specify a different SAN than the value stored in the mailing address. This is currently addressed with an override directly in the JEDI (pre-EDI Attributes) template. EDI Attributes no longer supports template overrides -- short of modifying the code -- so there's no way to address our SAN mismatch with the new code.

I propose a new acq.provider.buyer_san field that, when a value is present, overrides the value found in the ordering agency (org unit) mailing address.

Revision history for this message
Bill Erickson (berick) wrote :
tags: added: pullrequest
Changed in evergreen:
milestone: 3.8-beta → 3.next
tags: added: acq-edi
removed: edi
Revision history for this message
Tiffany Little (tslittle) wrote :

1. Would process_message_buyer in EDI.pm also need to be updated to reflect this alternate SAN so order responses/invoices are attached to the correct provider?

2. Even though "Buyer SAN" in the provider profile is technically correct, it's also potentially confusing language seeing as it's just two fields under "SAN." I think it would be helpful to either rename this "Alternate Library SAN"--as an example--or to add a tooltip that this should only be used for XYZ.

3. My totally non-technical inclination is that this field fits better under EDI accounts, since it's specifically only used when doing EDI ordering. Provider profiles are often accessible to a majority of Acq users, and EDI accounts might not always be (see bug 1916642). A user entering something in this field could potentially throw off their EDI orders because the vendor would be expecting the SAN from their mailing_address. That SAN is protected from unauthorized editing because getting into org unit settings requires a higher level of permissions.

Revision history for this message
Tiffany Little (tslittle) wrote :

Hi Bill, we applied this to a copy of our production data to test. When I put a pretend SAN in the new buyer_san field on the provider and run the test_edi script I'm not seeing the pretend SAN. Do I need to do anything after I add the new SAN?

Revision history for this message
Bill Erickson (berick) wrote :

Hi Tiffany, that's pretty much it. If there is a buyer_san on the PO provider, it should override the SAN on the org unit address.

Here's how I double-checked (change --po-id value to suit):

cd Open-ILS/src/support-scripts/test-scripts
./edi_writer.pl --po-id 43

---
UNA:+.? '
UNB+UNOB:3+VALUEHERE...
...

Changed in evergreen:
assignee: Bill Erickson (berick) → nobody
Bill Erickson (berick)
Changed in evergreen:
milestone: 3.next → 3.12-beta
Revision history for this message
Chris Sharp (chrissharp123) wrote :

Works for me! Pushed to main.

Changed in evergreen:
status: New → Fix Committed
tags: added: signedoff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.