Evergreen

Missing Did You Mean Prerequisites in Pg Server Installation Make Targets

Bug #1936662 reported by Jason Stephenson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Evergreen
Fix Released
High
Unassigned
Evergreen 3.7.2

Bug Description

Evergreen Version: 3.7.0
OpenSRF version: N/A
PostgreSQL Versions: 9.6 and 10
O/S: Debian Stretch (9.13) and Debian Buster (10.10), Ubuntu Bionic (18.04)

On the Debian distribution and Ubuntu Bionic, the CPAN modules, String::KeyboardDistance and Text::Levenshtein::Damerau::XS, are missing from the PostgreSQL server prerequisite installation Makefile targets. Since they are required for a successful database upgrade and creation, they should be added for all supported distros and Pg versions.

Ubuntu Focal both installs the modules as expected.

This was mentioned in IRC: http://irc.evergreen-ils.org/evergreen/2021-07-16#i_487283

I have only tested on Debian Stretch and Debian Buster, but I assume that Debian Jessie is also affected based on the code.

I'll supply a patch for all three, though I'd recommend against anyone using Jessie at this time.

See original description
Jason Stephenson (jstephenson)
summary: - Missing Did You Mean Prequisites in Pg Server Installation Make Targets
+ Missing Did You Mean Prerequisites in Pg Server Installation Make
+ Targets
Jason Stephenson (jstephenson)
description: updated
Jason Stephenson (jstephenson)
description: updated
Revision history for this message
Jason Stephenson (jstephenson) wrote :

Here's a branch with the promised updates: https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/dyrcona/lp1936662-debian-DYM-prereqs

I've tested it on Debian Stretch, Debian Buster, and Ubuntu Bionic. If someone wants to test on Jessie, too, that would be great.

It's pretty straightforward to test. You should run the PostgreSQL server Makefile.install targets and see that the String::KeyboardDistance and Text::Levenshtein::Damerau::XS modules are installed via CPAN. This is best done on a clean system where other prerequisites have not already been installed. Otherwise, it is more difficult to tell if the patch is working.

description: updated
Revision history for this message
Jason Stephenson (jstephenson) wrote :

I set this bug confirmed since Stephen Wills first reported it in IRC, and I confirmed it by looking at the code and testing on virtual machines.

tags: added: pullrequest
Changed in evergreen:
milestone: none → 3.8-beta
status: New → Confirmed
Revision history for this message
Jane Sandberg (sandbergja) wrote :

I can also confirm -- trying to install the database on Bionic currently fails due to these missing dependencies.

Signoff here: user/sandbergja/lp1936662-debian-DYM-prereqs

Bumping the importance, since it prevents the software from being installed normally.

Changed in evergreen:
importance: Undecided → High
Jane Sandberg (sandbergja)
tags: added: signedoff
Galen Charlton (gmc)
Changed in evergreen:
milestone: 3.8-beta → 3.7.2
no longer affects: evergreen/3.7
Revision history for this message
Galen Charlton (gmc) wrote :

Tested and pushed to master and rel_3_7. Thanks, Jason and Jane!

Changed in evergreen:
assignee: nobody → Galen Charlton (gmc)
assignee: Galen Charlton (gmc) → nobody
status: Confirmed → Fix Committed
Evergreen Bug Maintenance (bugmaster)
Changed in evergreen:
status: Fix Committed → Fix Released
Jeff Davis (jdavis-sitka)
tags: added: didyoumean
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.